Re: [12] Review Request: 8211822 and 8202886

2018-11-04 Thread Philip Race
- From: Krishna Addepalli Sent: Wednesday, October 31, 2018 1:35 PM To: Jayathirth D V ; Sergey Bylokhov Cc: awt-dev@openjdk.java.net; Igor Ignatyev Subject: Re: [12] Review Request: 8211822 and 8202886 Hi Sergey, Could you update the test use @requires tag, instead of relying on Platform

Re: [12] Review Request: 8211822 and 8202886

2018-11-02 Thread Sergey Bylokhov
PM To: Jayathirth D V ; Sergey Bylokhov Cc: awt-dev@openjdk.java.net; Igor Ignatyev Subject: Re: [12] Review Request: 8211822 and 8202886 Hi Sergey, Could you update the test use @requires tag, instead of relying on Platform for NSTexturedJFrame.java? This would probably make the test skip

Re: [12] Review Request: 8211822 and 8202886

2018-11-01 Thread Krishna Addepalli
okhov >> >> Cc: awt-dev@openjdk.java.net; Igor Ignatyev >> Subject: Re: [12] Review Request: 8211822 and 8202886 >> Hi Sergey, >> Could you update the test use @requires tag, instead of relying on Platform >> for NSTexturedJFrame.java? >> This would prob

Re: [12] Review Request: 8211822 and 8202886

2018-11-01 Thread Sergey Bylokhov
PM To: Jayathirth D V ; Sergey Bylokhov Cc: awt-dev@openjdk.java.net; Igor Ignatyev Subject: Re: [12] Review Request: 8211822 and 8202886 Hi Sergey, Could you update the test use @requires tag, instead of relying on Platform for NSTexturedJFrame.java? This would probably make the test skip

Re: [12] Review Request: 8211822 and 8202886

2018-10-31 Thread Krishna Addepalli
Also consider adding it for bug7154841, bug8007006.java. -Original Message- From: Krishna Addepalli Sent: Wednesday, October 31, 2018 1:35 PM To: Jayathirth D V ; Sergey Bylokhov Cc: awt-dev@openjdk.java.net; Igor Ignatyev Subject: Re: [12] Review Request: 8211822 and 8202886 Hi

Re: [12] Review Request: 8211822 and 8202886

2018-10-31 Thread Krishna Addepalli
: Sergey Bylokhov Cc: awt-dev@openjdk.java.net; Igor Ignatyev Subject: Re: [12] Review Request: 8211822 and 8202886 Changes are fine. Thanks, Jay > On 31-Oct-2018, at 12:19 PM, Sergey Bylokhov > wrote: > > HI, Jay. > > The fix is updated: > http://cr.openjdk.java.net/~s

Re: [12] Review Request: 8211822 and 8202886

2018-10-30 Thread Jayathirth Rao
11822. >> Thanks, >> Jay >> -Original Message- >> From: Sergey Bylokhov >> Sent: Tuesday, October 30, 2018 6:25 AM >> To: Igor Ignatyev >> Cc: awt-dev@openjdk.java.net >> Subject: Re: [12] Review Request: 8211822 and 8202886 >> Hi, Igo

Re: [12] Review Request: 8211822 and 8202886

2018-10-30 Thread Sergey Bylokhov
please update ProblemList accordingly. I will close JDK-8213122 as duplicate of JDK-8211822. Thanks, Jay -Original Message- From: Sergey Bylokhov Sent: Tuesday, October 30, 2018 6:25 AM To: Igor Ignatyev Cc: awt-dev@openjdk.java.net Subject: Re: [12] Review Request: 8211822 and 8202886 Hi

Re: [12] Review Request: 8211822 and 8202886

2018-10-30 Thread Jayathirth D V
Subject: Re: [12] Review Request: 8211822 and 8202886 Hi, Igor. Thank you for review. Any volunteers for the second review? =) On 10/10/2018 20:04, Igor Ignatyev wrote: > Hi Sergey, > > the changes in NSTexturedJFrame and 7154841 tests look good to me. > > -- Igor > >>

Re: [12] Review Request: 8211822 and 8202886

2018-10-29 Thread Sergey Bylokhov
Hi, Igor. Thank you for review. Any volunteers for the second review? =) On 10/10/2018 20:04, Igor Ignatyev wrote: Hi Sergey, the changes in NSTexturedJFrame and 7154841 tests look good to me. -- Igor On Oct 7, 2018, at 4:41 PM, Sergey Bylokhov wrote: Hello. Please review the fix for jdk12

Re: [12] Review Request: 8211822 and 8202886

2018-10-10 Thread Igor Ignatyev
Hi Sergey, the changes in NSTexturedJFrame and 7154841 tests look good to me. -- Igor > On Oct 7, 2018, at 4:41 PM, Sergey Bylokhov > wrote: > > Hello. > Please review the fix for jdk12. > > Bug: Some tests fail after JDK-8210039 > https://bugs.openjdk.java.net/browse/JDK-8211822 > Bug:

[12] Review Request: 8211822 and 8202886

2018-10-07 Thread Sergey Bylokhov
Hello. Please review the fix for jdk12. Bug: Some tests fail after JDK-8210039 https://bugs.openjdk.java.net/browse/JDK-8211822 Bug: [macos] Test java/awt/MenuBar/8007006/bug8007006.java fails on MacOS https://bugs.openjdk.java.net/browse/JDK-8202886 Webrev: http://cr.openjdk.java.net/~