Re: [12] Review Request: 8214918 Unify GraphicsEnvironment.getCenterPoint()/getMaximumWindowBounds() across the platforms

2019-01-25 Thread Sergey Bylokhov
On 23/01/2019 14:59, Phil Race wrote: So the code changes are OK if this is the direction but you pointed yourself to where the existing behaviour was documented, so if that documentation page exists still for current releases, it seems it needs to be updated, and if not you should do a releas

Re: [12] Review Request: 8214918 Unify GraphicsEnvironment.getCenterPoint()/getMaximumWindowBounds() across the platforms

2019-01-23 Thread Phil Race
So the code changes are OK if this is the direction but you pointed yourself to where the existing behaviour was documented, so if that documentation page exists still for current releases, it seems it needs to be updated, and if not you should do a release note for this change. -phil. On 12/

Re: [12] Review Request: 8214918 Unify GraphicsEnvironment.getCenterPoint()/getMaximumWindowBounds() across the platforms

2019-01-15 Thread Alexey Ivanov
Hi Sergey, The change looks good to me. On 20/12/2018 23:06, Sergey Bylokhov wrote: On 20/12/2018 10:57, Phil Race wrote: The synopsis made me think this was refactoring. But when I read it, it seems to be proposing removing the ability to centre a window on a Xinerama desktop, with the princi

Re: [12] Review Request: 8214918 Unify GraphicsEnvironment.getCenterPoint()/getMaximumWindowBounds() across the platforms

2018-12-20 Thread Sergey Bylokhov
On 20/12/2018 10:57, Phil Race wrote: The synopsis made me think this was refactoring. But when I read it, it seems to be proposing removing the ability to centre a window on a Xinerama desktop, with the principal justification that this was only ever something that worked on Solaris.> Is this a

Re: [12] Review Request: 8214918 Unify GraphicsEnvironment.getCenterPoint()/getMaximumWindowBounds() across the platforms

2018-12-20 Thread Phil Race
The synopsis made me think this was refactoring. But when I read it, it seems to be proposing removing the ability to centre a window on a Xinerama desktop, with the principal justification that this was only ever something that worked on Solaris. Is this absolutely necessary ? Does that mean th

Re: [12] Review Request: 8214918 Unify GraphicsEnvironment.getCenterPoint()/getMaximumWindowBounds() across the platforms

2018-12-19 Thread Krishna Addepalli
Hi Sergey,   The changes look fine to me.   Thanks, Krishna Subject: [12] Review Request: 8214918 Unify GraphicsEnvironment.getCenterPoint()/getMaximumWindowBounds() across the platforms Date: Thu, 6 Dec 2018 09:26:06 -0800 From: Sergey Bylokhov HYPERLINK

[12] Review Request: 8214918 Unify GraphicsEnvironment.getCenterPoint()/getMaximumWindowBounds() across the platforms

2018-12-06 Thread Sergey Bylokhov
Hello. Please review the fix for jdk 12. Bug: https://bugs.openjdk.java.net/browse/JDK-8214918 Webrev: http://cr.openjdk.java.net/~serb/8214918/webrev.00 In the fix for JDK-8076313 I need to implement possibility of switch between xinerama and non-xinerama modes at runtime. As a separate part I