[12] Review request for JDK-8208290: [TEST_BUG] The maximized unfocusable frame can be resized

Fri, 30 Nov 2018 03:32:24 -0800

Hi Prasanta,

Please review the fix for JDK12.

Issue:

Webrev:

Fix: 

    This webrev was sent earlier with issue 8208743 and contains a new test case. The root cause of both the issues are same and are related to the focusability of non-resizable Window (JTextArea). The previous review request mail is attached with this mail for reference.

Regards,

Manajit

{\rtf1\ansi\ansicpg1252\cocoartf1561\cocoasubrtf600
{\fonttbl\f0\fnil\fcharset0 HelveticaNeue;\f1\fswiss\fcharset0 Helvetica;\f2\froman\fcharset0 Times-Roman;
}
{\colortbl;\red255\green255\blue255;\red0\green0\blue0;\red0\green0\blue0;\red9\green80\blue208;
\red69\green60\blue204;\red20\green160\blue194;}
{\*\expandedcolortbl;;\csgray\c0;\cssrgb\c0\c0\c0;\cssrgb\c0\c41176\c85098;
\cssrgb\c34510\c33725\c83922;\cssrgb\c0\c68627\c80392;}
\pard\tx560\tx1120\tx1680\tx2240\tx2800\tx3360\tx3920\tx4480\tx5040\tx5600\tx6160\tx6720\pardirnatural\partightenfactor0

\f0\fs24 \cf2 From: Manajit Halder <manajit.hal...@oracle.com>\
Subject: Re: <AWT dev>[12] Review request for JDK-8208743: JDialog with JTextArea can't accept focus when setResizable(false) called\
Date: 20 August 2018 at 11:50:37 AM IST\
To: Prasanta Sadhukhan <prasanta.sadhuk...@oracle.com>, sergey.bylok...@oracle.com\
Cc: awt-dev@openjdk.java.net\
\pard\tx560\tx1120\tx1680\tx2240\tx2800\tx3360\tx3920\tx4480\tx5040\tx5600\tx6160\tx6720\pardirnatural\partightenfactor0

\f1 \cf2 \
\pard\pardeftab720\sl280\sa240\partightenfactor0
\cf3 \expnd0\expndtw0\kerning0
\outl0\strokewidth0 \strokec3 Hi Prasanta,\
Thanks for your suggestion. Will close this issue as duplicate of 8202125 and add test code in webrev along with fix of {\field{\*\fldinst{HYPERLINK "https://bugs.openjdk.java.net/browse/JDK-8208290"}}{\fldrslt \cf4 \ul \ulc4 \strokec4 JDK-8208290}} instead of bug 8208125, as it is related to 8208290.\
Regards, \uc0\u8232 \
Manajit\uc0\u8232 \
\uc0\u8232 \
\pard\pardeftab720\sl280\partightenfactor0
\cf3 On 17/08/18 2:34 PM, Prasanta Sadhukhan wrote:\
\pard\pardeftab720\sl280\sa240\partightenfactor0
\cf5 \strokec5 Hi Manajit,\uc0\u8232 \
\pard\pardeftab720\sl280\partightenfactor0
\cf5 Although it looks good, but I guess having JBS issue to just create a testcase may not be right. My take is close this as duplicate of 8208125 and add this testcase when you fix {\field{\*\fldinst{HYPERLINK "https://bugs.openjdk.java.net/browse/JDK-8209123"}}{\fldrslt \cf4 \ul \ulc4 \strokec4 8209123}}\
\
Regards\
Prasanta\
On 8/16/2018 5:11 PM, Manajit Halder wrote:\
\pard\pardeftab720\sl280\sa240\partightenfactor0
\cf6 \strokec6 Hi All,\uc0\u8232 \u8232 Please review the fix for JDK12.\u8232 \u8232 
\f2 \uc0\u8232 \u8232 
\f1 Bug: \uc0\u8232 \'a0\'a0\'a0\'a0 {\field{\*\fldinst{HYPERLINK "https://bugs.openjdk.java.net/browse/JDK-8208743"}}{\fldrslt \cf4 \ul \ulc4 \strokec4 https://bugs.openjdk.java.net/browse/JDK-8208743}}\uc0\u8232 \u8232 
\f2 \uc0\u8232 
\f1 Webrev: 
\f2 \uc0\u8232 
\f1 \uc0\u8232 \'a0\'a0\'a0 {\field{\*\fldinst{HYPERLINK "http://cr.openjdk.java.net/%7Emhalder/8208743/webrev.00/"}}{\fldrslt \cf4 \ul \ulc4 \strokec4 http://cr.openjdk.java.net/~mhalder/8208743/webrev.00/}}\
Fix: 
\f2 \uc0\u8232 
\f1 \uc0\u8232 \'a0\'a0\'a0 This reported issue is resolved by fix of issue JDK-8208125, which is checked-in to JDK 11 repo. The webrev contains a test case to test the focusability of non-resizable JTextArea.\
Regards,\uc0\u8232 Manajit\u8232 \
\uc0\u8232 \
\pard\pardeftab720\sl280\partightenfactor0
\cf5 \strokec5 \
\pard\pardeftab720\sl280\partightenfactor0
\cf3 \strokec3 \
}

Reply via email to