Re: [13] Review Request: 8216318 The usage of Disposer in the java.awt.Robot can be deleted

2019-01-30 Thread Sergey Bylokhov
On 30/01/2019 13:53, Phil Race wrote: Looks fine. I can only suppose the C++ AwtRobot class existed only because other peer classes need a C++ native object ? I guess it was implemented with assumption that the robot will need to store some data in the native code, but in fact it was always an

Re: [13] Review Request: 8216318 The usage of Disposer in the java.awt.Robot can be deleted

2019-01-30 Thread Phil Race
Looks fine. I can only suppose the C++ AwtRobot class existed only because other peer classes need a C++ native object ? But I can't think what would break if there's none here ... -phil. On 1/11/19 6:45 PM, Sergey Bylokhov wrote: Hello. Please review the fix for jdk 13. Bug: https://bugs.open

[13] Review Request: 8216318 The usage of Disposer in the java.awt.Robot can be deleted

2019-01-11 Thread Sergey Bylokhov
Hello. Please review the fix for jdk 13. Bug: https://bugs.openjdk.java.net/browse/JDK-8216318 Webrev: http://cr.openjdk.java.net/~serb/8216318/webrev.01 Every java.awt.Robot object register a RobotDisposer which are responsible to delete the native data of the robot. But there is no native data