Re: [8] RFR for 8150258: [TEST] HiDPI: create a test for multiresolution menu items icons

2016-03-04 Thread Alexander Stepanov
Thanks! On 3/4/2016 6:31 PM, Yuri Nesterenko wrote: +1 -yan On 03/04/2016 06:13 PM, Sergey Bylokhov wrote: Looks fine. On 29.02.16 18:45, Alexander Stepanov wrote: The following version of the test passes for OS X + retina (as well as for Windows and Linux):

Re: [8] RFR for 8150258: [TEST] HiDPI: create a test for multiresolution menu items icons

2016-03-04 Thread Yuri Nesterenko
+1 -yan On 03/04/2016 06:13 PM, Sergey Bylokhov wrote: Looks fine. On 29.02.16 18:45, Alexander Stepanov wrote: The following version of the test passes for OS X + retina (as well as for Windows and Linux): http://cr.openjdk.java.net/~avstepan/8150258/webrev.01/ not sure if

Re: [8] RFR for 8150258: [TEST] HiDPI: create a test for multiresolution menu items icons

2016-03-04 Thread Alexander Stepanov
Thank you! On 3/4/2016 6:13 PM, Sergey Bylokhov wrote: Looks fine. On 29.02.16 18:45, Alexander Stepanov wrote: The following version of the test passes for OS X + retina (as well as for Windows and Linux): http://cr.openjdk.java.net/~avstepan/8150258/webrev.01/ not sure if

Re: [8] RFR for 8150258: [TEST] HiDPI: create a test for multiresolution menu items icons

2016-03-04 Thread Sergey Bylokhov
Looks fine. On 29.02.16 18:45, Alexander Stepanov wrote: The following version of the test passes for OS X + retina (as well as for Windows and Linux): http://cr.openjdk.java.net/~avstepan/8150258/webrev.01/ not sure if "-Dsun.java2d.uiScale" option was intended for use with OS X (probably an

Re: [8] RFR for 8150258: [TEST] HiDPI: create a test for multiresolution menu items icons

2016-02-29 Thread Alexander Stepanov
Please see JDK-8150844 On 2/29/2016 6:52 PM, Sergey Bylokhov wrote: On 29.02.16 18:45, Alexander Stepanov wrote: not sure if "-Dsun.java2d.uiScale" option was intended for use with OS X (probably an enhancement bug should be created). So for OS X now we have only single test run in fact. I

Re: [8] RFR for 8150258: [TEST] HiDPI: create a test for multiresolution menu items icons

2016-02-29 Thread Sergey Bylokhov
On 29.02.16 18:45, Alexander Stepanov wrote: not sure if "-Dsun.java2d.uiScale" option was intended for use with OS X (probably an enhancement bug should be created). So for OS X now we have only single test run in fact. I do not remember that such request was filed, please file a separate

Re: [8] RFR for 8150258: [TEST] HiDPI: create a test for multiresolution menu items icons

2016-02-29 Thread Alexander Stepanov
The following version of the test passes for OS X + retina (as well as for Windows and Linux): http://cr.openjdk.java.net/~avstepan/8150258/webrev.01/ not sure if "-Dsun.java2d.uiScale" option was intended for use with OS X (probably an enhancement bug should be created). So for OS X now we

Re: [8] RFR for 8150258: [TEST] HiDPI: create a test for multiresolution menu items icons

2016-02-29 Thread Alexander Stepanov
Hello Sergey, When running the following trivial test case (having Color set to "Generic RGB Profile") import java.awt.*; public class ColorTest extends Frame { private void UI() { setSize(100, 100); setBackground(Color.BLUE); setVisible(true); } public

Re: [8] RFR for 8150258: [TEST] HiDPI: create a test for multiresolution menu items icons

2016-02-26 Thread Alexander Stepanov
It seemingly does not help (but maybe I'm doing something wrong). On 2/26/2016 5:45 PM, Sergey Bylokhov wrote: On 26.02.16 17:27, Alexander Stepanov wrote: It seems that for osx + retina 1. -Dsun.java2d.uiScale option is ignored for multires. image (in contrast for HiDPI + Win. 8, for

Re: [8] RFR for 8150258: [TEST] HiDPI: create a test for multiresolution menu items icons

2016-02-26 Thread Sergey Bylokhov
On 26.02.16 17:27, Alexander Stepanov wrote: It seems that for osx + retina 1. -Dsun.java2d.uiScale option is ignored for multires. image (in contrast for HiDPI + Win. 8, for example). Should it be considered as a bug? At a 1st glance, yes. 2. even in case of correct color robot's

Re: [8] RFR for 8150258: [TEST] HiDPI: create a test for multiresolution menu items icons

2016-02-26 Thread Alexander Stepanov
It seems that for osx + retina 1. -Dsun.java2d.uiScale option is ignored for multires. image (in contrast for HiDPI + Win. 8, for example). Should it be considered as a bug? At a 1st glance, yes. 2. even in case of correct color robot's getPixelColor() returns for retina a bit shifted color

Re: [8] RFR for 8150258: [TEST] HiDPI: create a test for multiresolution menu items icons

2016-02-26 Thread Alexander Stepanov
Hello Sergey, No, as well as for 8150724. I have to re-check, thank you. Regards, Alexander On 2/26/2016 4:36 PM, Sergey Bylokhov wrote: Hi, Alexander. The test failed on my OSX 10.11 + retina. Is it expected? On 25.02.16 17:51, Alexander Stepanov wrote: Sorry, just a reminder. Thanks,

Re: [8] RFR for 8150258: [TEST] HiDPI: create a test for multiresolution menu items icons

2016-02-26 Thread Sergey Bylokhov
Hi, Alexander. The test failed on my OSX 10.11 + retina. Is it expected? On 25.02.16 17:51, Alexander Stepanov wrote: Sorry, just a reminder. Thanks, Alexander On 2/19/2016 7:17 PM, Alexander Stepanov wrote: Hello, Could you please review the following fix

[8] RFR for 8150258: [TEST] HiDPI: create a test for multiresolution menu items icons

2016-02-25 Thread Alexander Stepanov
Sorry, just a reminder. Thanks, Alexander On 2/19/2016 7:17 PM, Alexander Stepanov wrote: Hello, Could you please review the following fix http://cr.openjdk.java.net/~avstepan/8150258/webrev.00/ for https://bugs.openjdk.java.net/browse/JDK-8150258 Just a single test added. Thanks, Alexander