Re: [8] Request for review: 7150100 [macosx] "0123456789" is selected in the TextField.

2013-09-30 Thread Artem Ananiev
The new version of the fix still looks fine. Thanks, Artem On 9/27/2013 2:13 PM, Sergey Bylokhov wrote: Hello. Please review the updated version of the fix for jdk 8. The same problem was found and fixed in xawt as well. http://cr.openjdk.java.net/~serb/7150100/webrev.01 On 09.04.2012 15:03,

Re: [8] Request for review: 7150100 [macosx] "0123456789" is selected in the TextField.

2013-09-27 Thread Sergey Bylokhov
On 27.09.2013 16:36, Anthony Petrov wrote: On 09/27/2013 04:32 PM, Sergey Bylokhov wrote: On 27.09.2013 16:15, Anthony Petrov wrote: Hi Sergey, Where is the comment that you say you've added? I'd expect to see it above the setCaretPosition() calls. It was added to bug evaluation in the bug co

Re: [8] Request for review: 7150100 [macosx] "0123456789" is selected in the TextField.

2013-09-27 Thread Anthony Petrov
On 09/27/2013 04:32 PM, Sergey Bylokhov wrote: On 27.09.2013 16:15, Anthony Petrov wrote: Hi Sergey, Where is the comment that you say you've added? I'd expect to see it above the setCaretPosition() calls. It was added to bug evaluation in the bug comment. This might better be documented in

Re: [8] Request for review: 7150100 [macosx] "0123456789" is selected in the TextField.

2013-09-27 Thread Sergey Bylokhov
On 27.09.2013 16:15, Anthony Petrov wrote: Hi Sergey, Where is the comment that you say you've added? I'd expect to see it above the setCaretPosition() calls. It was added to bug evaluation in the bug comment. src/solaris/classes/sun/awt/X11/XTextAreaPeer.java 410 public void setEditab

Re: [8] Request for review: 7150100 [macosx] "0123456789" is selected in the TextField.

2013-09-27 Thread Anthony Petrov
Hi Sergey, Where is the comment that you say you've added? I'd expect to see it above the setCaretPosition() calls. src/solaris/classes/sun/awt/X11/XTextAreaPeer.java 410 public void setEditable(boolean editable) { 411 this.editable = editable; Why do you delete this assignmen

Re: [8] Request for review: 7150100 [macosx] "0123456789" is selected in the TextField.

2013-09-27 Thread Sergey Bylokhov
Hello. Please review the updated version of the fix for jdk 8. The same problem was found and fixed in xawt as well. http://cr.openjdk.java.net/~serb/7150100/webrev.01 On 09.04.2012 15:03, Artem Ananiev wrote: On 4/6/2012 8:25 PM, Sergey Bylokhov wrote: 05.04.2012 14:53, Artem Ananiev написал:

Re: [8] Request for review: 7150100 [macosx] "0123456789" is selected in the TextField.

2012-04-09 Thread Artem Ananiev
On 4/6/2012 8:25 PM, Sergey Bylokhov wrote: 05.04.2012 14:53, Artem Ananiev написал: Hi, Sergey, On 3/28/2012 8:05 PM, Sergey Bylokhov wrote: Hi Everyone, Two issues resolved: 1) We should set caret position before the text selection. it's not clear why this particular change fixes the sele

Re: [8] Request for review: 7150100 [macosx] "0123456789" is selected in the TextField.

2012-04-06 Thread Sergey Bylokhov
05.04.2012 14:53, Artem Ananiev написал: Hi, Sergey, On 3/28/2012 8:05 PM, Sergey Bylokhov wrote: Hi Everyone, Two issues resolved: 1) We should set caret position before the text selection. it's not clear why this particular change fixes the selection. Could you add more comments to the bug

Re: [8] Request for review: 7150100 [macosx] "0123456789" is selected in the TextField.

2012-04-05 Thread Alexander Potochkin
Hello Sergey looks good alexp Hi Everyone, Two issues resolved: 1) We should set caret position before the text selection. 2) On macosx we clear selection when the test component lost its focus, so test was simplified and instructions dialog was removed (because sometimes it steal the focus

Re: [8] Request for review: 7150100 [macosx] "0123456789" is selected in the TextField.

2012-04-05 Thread Artem Ananiev
Hi, Sergey, On 3/28/2012 8:05 PM, Sergey Bylokhov wrote: Hi Everyone, Two issues resolved: 1) We should set caret position before the text selection. it's not clear why this particular change fixes the selection. Could you add more comments to the bug evaluation, please? Thanks, Artem 2)

Re: [8] Request for review: 7150100 [macosx] "0123456789" is selected in the TextField.

2012-03-29 Thread Sergey Bylokhov
Hi Mike. 28.03.2012 20:18, Mike Swingler wrote: Does this change the behavior of where the cursor ends up if you press the left or right keys while there is a selection? We get this wrong in Java SE 6, and I was wondering if this corrects that behavior. Regards, Mike Swingler Apple Inc. No. I

Re: [8] Request for review: 7150100 [macosx] "0123456789" is selected in the TextField.

2012-03-28 Thread Mike Swingler
On Mar 28, 2012, at 9:05 AM, Sergey Bylokhov wrote: > Hi Everyone, > Two issues resolved: > 1) We should set caret position before the text selection. > 2) On macosx we clear selection when the test component lost its focus, so > test was simplified and instructions dialog was removed (because s

[8] Request for review: 7150100 [macosx] "0123456789" is selected in the TextField.

2012-03-28 Thread Sergey Bylokhov
Hi Everyone, Two issues resolved: 1) We should set caret position before the text selection. 2) On macosx we clear selection when the test component lost its focus, so test was simplified and instructions dialog was removed (because sometimes it steal the focus from the text component) Bug: ht