Re: [8] Request for review: 8005255 [macosx] Cleanup warnings in sun.lwawt

2013-09-16 Thread Anthony Petrov
Thanks for the clarifications. Provided the formatting is fixed, I'm fine with the fix. -- best regards, Anthony On 09/16/13 17:36, Sergey Bylokhov wrote: On 16.09.2013 17:08, Anthony Petrov wrote: Hi Sergey, 1. There's some change in RepaintArea logic in LWRepaintArea.java. I'd suggest to p

Re: [8] Request for review: 8005255 [macosx] Cleanup warnings in sun.lwawt

2013-09-16 Thread Sergey Bylokhov
On 16.09.2013 17:08, Anthony Petrov wrote: Hi Sergey, 1. There's some change in RepaintArea logic in LWRepaintArea.java. I'd suggest to push these changes as a separate fix. There are 2 changed in the file: - javadoc - flushOnscreenGraphics() is a static method and now it is called via clas

Re: [8] Request for review: 8005255 [macosx] Cleanup warnings in sun.lwawt

2013-09-16 Thread Anthony Petrov
Hi Sergey, 1. There's some change in RepaintArea logic in LWRepaintArea.java. I'd suggest to push these changes as a separate fix. 2. LWWindowPeer.java 46 public enum PeerType { Why should it not be static? 3. 132 LWWindowPeer ownerPeer = (owner != null) ? (LWWindowPeer) AW

Re: [8] Request for review: 8005255 [macosx] Cleanup warnings in sun.lwawt

2013-09-13 Thread Alexander Scherbatiy
The fix looks good for me. Thanks, Alexandr. On 9/12/2013 6:53 PM, Sergey Bylokhov wrote: Hello, Please review the fix for jdk 8. - Documentation updated - Component.getPeer() replaced with AWTAccessor. - Generics code updated. - For some methods access was changed to weaker

[8] Request for review: 8005255 [macosx] Cleanup warnings in sun.lwawt

2013-09-12 Thread Sergey Bylokhov
Hello, Please review the fix for jdk 8. - Documentation updated - Component.getPeer() replaced with AWTAccessor. - Generics code updated. - For some methods access was changed to weaker - SuppressWarnings were added when needed. Plus some small general cleanup. Bug: http://bugs.sun.com/bu