Re: [8] Review Request: JDK-8016563 Test closed/java/awt/dnd/ImageTransferTest/ImageTransferTest.html fails

2013-09-27 Thread Anthony Petrov
Looks good. -- best regards, Anthony On 09/27/2013 03:04 PM, Petr Pchelko wrote: Hello, AWT Team. Please review the updated fix here: http://cr.openjdk.java.net/~pchelko/8015563/webrev.01/ We actually need to throw an exception in case the Data conversion failed. With best regards. Petr. On

Re: [8] Review Request: JDK-8016563 Test closed/java/awt/dnd/ImageTransferTest/ImageTransferTest.html fails

2013-09-27 Thread Sergey Bylokhov
Hi, Petr. The fix looks good. But i am sure the code simplification is required. On 27.09.2013 15:04, Petr Pchelko wrote: Hello, AWT Team. Please review the updated fix here: http://cr.openjdk.java.net/~pchelko/8015563/webrev.01/ We actually need to throw an exception in case the Data conversi

Re: [8] Review Request: JDK-8016563 Test closed/java/awt/dnd/ImageTransferTest/ImageTransferTest.html fails

2013-09-27 Thread Petr Pchelko
Hello, AWT Team. Please review the updated fix here: http://cr.openjdk.java.net/~pchelko/8015563/webrev.01/ We actually need to throw an exception in case the Data conversion failed. With best regards. Petr. On Sep 27, 2013, at 2:47 PM, Petr Pchelko wrote: > Hello, AWT Team. > > Please revie

[8] Review Request: JDK-8016563 Test closed/java/awt/dnd/ImageTransferTest/ImageTransferTest.html fails

2013-09-27 Thread Petr Pchelko
Hello, AWT Team. Please review the fix for the issue: https://bugs.openjdk.java.net/browse/JDK-8016563 The fix is available at: http://cr.openjdk.java.net/~pchelko/8015563/webrev.00/ This is a regression of the fix for JDK-7075105. On of the if clauses was lost during refactoring. With best reg