Re: [8] Review request for 7129133: [macosx] Accelerators are displayed as Meta instead of the Command symbol

2013-09-19 Thread Sergey Bylokhov
d you review it, please? ---- Original Message ---- Subject: [8] Review request for 7129133: [macosx] Accelerators are displayed as Meta instead of the Command symbol Date: Wed, 11 Sep 2013 13:24:32 +0400 From: Leonid Romanov To: awt-dev CC: macosx-port-...@openjdk.java.ne

Re: [8] Review request for 7129133: [macosx] Accelerators are displayed as Meta instead of the Command symbol

2013-09-19 Thread Leonid Romanov
our shared code. >>>>>> >>>>>> -- >>>>>> best regards, >>>>>> Anthony >>>>>> >>>>>> On 09/12/13 15:30, Leonid Romanov wrote: >>>>>>> Yes, I'll use OSInfo i

Re: [8] Review request for 7129133: [macosx] Accelerators are displayed as Meta instead of the Command symbol

2013-09-19 Thread Sergey Bylokhov
wrote: Hi, Leonid. i think that you can try to reuse OSInfo class. Also I doubt about property file name. On 12.09.2013 9:09, Leonid Romanov wrote: Hi guys, Could you review it, please? -------- Original Message -------- Subject: [8] Review request for 7129133: [macosx] Accelerators are disp

Re: [8] Review request for 7129133: [macosx] Accelerators are displayed as Meta instead of the Command symbol

2013-09-13 Thread Anthony Petrov
Hi guys, Could you review it, please? -------- Original Message Subject:[8] Review request for 7129133: [macosx] Accelerators are displayed as Meta instead of the Command symbol Date: Wed, 11 Sep 2013 13:24:32 +0400 From: Leonid Romanov To: awt-dev CC: macosx-port-.

Re: [8] Review request for 7129133: [macosx] Accelerators are displayed as Meta instead of the Command symbol

2013-09-13 Thread Leonid Romanov
t;>> On 12.09.2013, at 15:26, Sergey Bylokhov >>> <mailto:sergey.bylok...@oracle.com>> wrote: >>>> >>>>> Hi, Leonid. >>>>> i think that you can try to reuse OSInfo class. >>>>> Also I doubt about property file name.

Re: [8] Review request for 7129133: [macosx] Accelerators are displayed as Meta instead of the Command symbol

2013-09-13 Thread Anthony Petrov
ame. On 12.09.2013 9:09, Leonid Romanov wrote: Hi guys, Could you review it, please? ---- Original Message ---- Subject: [8] Review request for 7129133: [macosx] Accelerators are displayed as Meta instead of the Command symbol Date: Wed, 11 Sep 2013 13:24:32 +0400 From

Re: [8] Review request for 7129133: [macosx] Accelerators are displayed as Meta instead of the Command symbol

2013-09-13 Thread Leonid Romanov
.09.2013 9:09, Leonid Romanov wrote: >>>> Hi guys, >>>> Could you review it, please? >>>> >>>> Original Message >>>> Subject: [8] Review request for 7129133: [macosx] Accelerators are >>>> displayed as Met

Re: [8] Review request for 7129133: [macosx] Accelerators are displayed as Meta instead of the Command symbol

2013-09-12 Thread Anthony Petrov
manov wrote: Hi guys, Could you review it, please? Original Message Subject: [8] Review request for 7129133: [macosx] Accelerators are displayed as Meta instead of the Command symbol Date: Wed, 11 Sep 2013 13:24:32 +0400 From: Leonid Romanov To: awt-dev CC:

Re: [8] Review request for 7129133: [macosx] Accelerators are displayed as Meta instead of the Command symbol

2013-09-12 Thread Leonid Romanov
Romanov wrote: >> Hi guys, >> Could you review it, please? >> >> Original Message ---- >> Subject: [8] Review request for 7129133: [macosx] Accelerators are >> displayed as Meta instead of the Command symbol >> Date:Wed, 11 Sep 2

Re: Fwd: [8] Review request for 7129133: [macosx] Accelerators are displayed as Meta instead of the Command symbol

2013-09-12 Thread Sergey Bylokhov
Hi, Leonid. i think that you can try to reuse OSInfo class. Also I doubt about property file name. On 12.09.2013 9:09, Leonid Romanov wrote: Hi guys, Could you review it, please? Original Message Subject: [8] Review request for 7129133: [macosx] Accelerators are displayed

Re: [8] Review request for 7129133: [macosx] Accelerators are displayed as Meta instead of the Command symbol

2013-09-11 Thread Magnus Ihse Bursie
On 2013-09-11 13:42, Erik Joelsson wrote: Build part of changes looks ok. I can't comment on the AWT part. :-) /Magnus /Erik On 2013-09-11 11:24, Leonid Romanov wrote: Hello, Please review a fix for 7129133: [macosx] Accelerators are displayed as Meta instead of the Command symbol. bu

Re: [8] Review request for 7129133: [macosx] Accelerators are displayed as Meta instead of the Command symbol

2013-09-11 Thread Erik Joelsson
Build part of changes looks ok. I can't comment on the AWT part. /Erik On 2013-09-11 11:24, Leonid Romanov wrote: Hello, Please review a fix for 7129133: [macosx] Accelerators are displayed as Meta instead of the Command symbol. bug: http://bugs.sun.com/view_bug.do?bug_id=7129133 webrev: http

[8] Review request for 7129133: [macosx] Accelerators are displayed as Meta instead of the Command symbol

2013-09-11 Thread Leonid Romanov
Hello, Please review a fix for 7129133: [macosx] Accelerators are displayed as Meta instead of the Command symbol. bug: http://bugs.sun.com/view_bug.do?bug_id=7129133 webrev: http://cr.openjdk.java.net/~leonidr/7129133/webrev.00/ Thanks, Leonid.