Re: [8] Review request for 8000425: FileDialog documentation should be enhanced

2013-10-02 Thread Anthony Petrov
The updated fix looks fine to me. Thanks! -- best regards, Anthony On 10/03/2013 12:18 AM, Oleg Pekhovskiy wrote: Hi Anthony, thank you for the review... Please, review the second version of fix here: http://cr.openjdk.java.net/~bagiras/8000425.2/ and my comments below... Thanks, Oleg On 2

Re: [8] Review request for 8000425: FileDialog documentation should be enhanced

2013-10-02 Thread Oleg Pekhovskiy
Hi Anthony, thank you for the review... Please, review the second version of fix here: http://cr.openjdk.java.net/~bagiras/8000425.2/ and my comments below... Thanks, Oleg On 25.09.2013 16:12, Anthony Petrov wrote: Hi Oleg, I suggest to rephrase the statements as follows: 460 * The

Re: [8] Review request for 8000425: FileDialog documentation should be enhanced

2013-09-25 Thread Anthony Petrov
Hi Oleg, I suggest to rephrase the statements as follows: 460 * The file could be highlighted or its name could be entered depending on 461 * native file dialog implementation. "When the dialog is shown, the specified file is selected. The kind of selection depends on the dialog

Re: [8] Review request for 8000425: FileDialog documentation should be enhanced

2013-09-25 Thread Sergey Bylokhov
Hi, Oleg. The fix looks good. On 25.09.2013 14:50, Oleg Pekhovskiy wrote: Hi all, please review the fix http://cr.openjdk.java.net/~bagiras/8000425.1/ for https://bugs.openjdk.java.net/browse/JDK-8000425 It's just a Javadoc fix. Thanks, Oleg -- Best regards, Sergey.

[8] Review request for 8000425: FileDialog documentation should be enhanced

2013-09-25 Thread Oleg Pekhovskiy
Hi all, please review the fix http://cr.openjdk.java.net/~bagiras/8000425.1/ for https://bugs.openjdk.java.net/browse/JDK-8000425 It's just a Javadoc fix. Thanks, Oleg