Re: [8] Review request for 8003965: Toolkit.beep() documentation is ambiguous

2013-09-09 Thread Anthony Petrov
Looks OK to me. Please get a CCC approval before pushing this fix. -- best regards, Anthony On 09/02/2013 05:18 PM, Oleg Pekhovskiy wrote: Hi Team, please review the second version of fix here: http://cr.openjdk.java.net/~bagiras/8003965.2/ Thanks, Oleg On 29.08.2013 16:05, Anthony Petrov w

Re: [8] Review request for 8003965: Toolkit.beep() documentation is ambiguous

2013-09-02 Thread Oleg Pekhovskiy
Hi Team, please review the second version of fix here: http://cr.openjdk.java.net/~bagiras/8003965.2/ Thanks, Oleg On 29.08.2013 16:05, Anthony Petrov wrote: Note that this change will also need a CCC request filed/approved before the fix may be pushed. -- best regards, Anthony On 08/29/13

Re: [8] Review request for 8003965: Toolkit.beep() documentation is ambiguous

2013-08-29 Thread Anthony Petrov
Note that this change will also need a CCC request filed/approved before the fix may be pushed. -- best regards, Anthony On 08/29/13 16:03, Anthony Petrov wrote: Hi Oleg, I believe that a javadoc shouldn't mention any particular native APIs used to implement a particular functionality, becaus

Re: [8] Review request for 8003965: Toolkit.beep() documentation is ambiguous

2013-08-29 Thread Anthony Petrov
Hi Oleg, I believe that a javadoc shouldn't mention any particular native APIs used to implement a particular functionality, because: 1. There are many more platforms where Java runs, and they also may implement the beep() method. 2. In the future we may need to change the underlying implem

[8] Review request for 8003965: Toolkit.beep() documentation is ambiguous

2013-08-29 Thread Oleg Pekhovskiy
Hi all, please review the fix for JDK-8003965 (not available on bugs.sun.com): http://cr.openjdk.java.net/~bagiras/8003965.1/ It's just a Javadoc fix. Thanks, Oleg