The fix looks good to me as well.
--
best regards,
Anthony
On 10/01/2013 08:06 PM, Leonid Romanov wrote:
I've investigated this issue and couldn't find a situation where the call to
XToolkit.targetDisposedPeer() from XBaseMenuWindow.doDispose() would make sense
(we call XToolkit.targetDispose
Hi, Leonid.
The fix looks good.
On 01.10.2013 20:06, Leonid Romanov wrote:
I've investigated this issue and couldn't find a situation where the call to
XToolkit.targetDisposedPeer() from XBaseMenuWindow.doDispose() would make sense
(we call XToolkit.targetDisposedPeer() with correct targets in
I've investigated this issue and couldn't find a situation where the call to
XToolkit.targetDisposedPeer() from XBaseMenuWindow.doDispose() would make sense
(we call XToolkit.targetDisposedPeer() with correct targets in XPopupMenuPeer
and XMenuBarPeer), so I decided to remove it to avoid any con
Yes, this code looked suspicious for me as well, I suspect it is a result of
copy pasting XWindow's dispose() code. For a wrong peer/target pair,
XToolkit.targetDisposedPeer() is a no-op, so no harm is done, but perhaps it
makes sense to remove that call altogether. I'll check it.
On Sep 27,
Hi, Leonid.
In this case the code in the XBaseMenuWindow.doDispose() call
XToolkit.targetDisposedPeer(target, this); for the wrong target? Or
probably this target is alwase null?
On 27.09.2013 20:32, Leonid Romanov wrote:
Hello,
Please review a fix for 8023994: Right click on the icon added t
Hello,
Please review a fix for 8023994: Right click on the icon added to the system
tray for the first time, java.lang.IllegalArgumentException thrown. The problem
here is that for popup menus the "target" field of XBaseMenuWindow class is not
a MenuComponent corresponding to the popup, but a co
