Re: [9] Review Request: 8141553 JDK fails to build with Xcode 7 on 10.11

2016-02-24 Thread Avik Niyogi
The updated fix looks good to me. > On 24-Feb-2016, at 11:02 pm, Sergey Bylokhov > wrote: > > On 11.02.16 8:52, Avik Niyogi wrote: >> Here is my two cents: >> >> * As of Xcode 7, Rich Text Font Document attributes have to be >>mentioned explicitly and not with a nil. >> >>I can see th

Re: [9] Review Request: 8141553 JDK fails to build with Xcode 7 on 10.11

2016-02-24 Thread Sergey Bylokhov
On 11.02.16 8:52, Avik Niyogi wrote: Here is my two cents: * As of Xcode 7, Rich Text Font Document attributes have to be mentioned explicitly and not with a nil. I can see that to mitigate the warning an empty array is placed there. The system is able to still process RTF documen

Re: [9] Review Request: 8141553 JDK fails to build with Xcode 7 on 10.11

2016-02-11 Thread Chris Bensen
> On Feb 10, 2016, at 9:16 AM, David DeHaven wrote: > > >> Please review one more iteration of the fix of warnings in awt on osx. >> The fix was contributed by Chris Bensen. >> >> Bug: https://bugs.openjdk.java.net/browse/JDK-8141553 >> Webrev can be found at: http://cr.openjdk.java.net/~serb/8

Re: [9] Review Request: 8141553 JDK fails to build with Xcode 7 on 10.11

2016-02-10 Thread Avik Niyogi
Here is my two cents: As of Xcode 7, Rich Text Font Document attributes have to be mentioned explicitly and not with a nil. I can see that to mitigate the warning an empty array is placed there. The system is able to still process RTF document with this. Ideally, the parameter to be passed for th

Re: [9] Review Request: 8141553 JDK fails to build with Xcode 7 on 10.11

2016-02-10 Thread David DeHaven
> Please review one more iteration of the fix of warnings in awt on osx. > The fix was contributed by Chris Bensen. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8141553 > Webrev can be found at: http://cr.openjdk.java.net/~serb/8141553/webrev.00 Thanks for doing this! I'm not a (R)eviewer,

[9] Review Request: 8141553 JDK fails to build with Xcode 7 on 10.11

2016-02-10 Thread Sergey Bylokhov
Hello. Please review one more iteration of the fix of warnings in awt on osx. The fix was contributed by Chris Bensen. Bug: https://bugs.openjdk.java.net/browse/JDK-8141553 Webrev can be found at: http://cr.openjdk.java.net/~serb/8141553/webrev.00 -- Best regards, Sergey.