Re: [9] Review request for 7033533: realSync() doesn't work with Xfce

2014-01-29 Thread Sergey Bylokhov
Hi, Oleg. The fix looks good. On 22.01.2014 20:31, Oleg Pekhovskiy wrote: Hi Team, There was a long break after last comment and now I'm able to continue discussion. Please review the second version of fix: http://cr.openjdk.java.net/~bagiras/7033533.2/ I investigated the order of different

Re: [9] Review request for 7033533: realSync() doesn't work with Xfce

2014-01-24 Thread Anthony Petrov
Sounds good. I'm fine with the fix then, provided it's been tested thoroughly on all supported configurations (including OEL and Solaris systems that we support). -- best regards, Anthony On 1/24/2014 5:26 PM, Oleg Pekhovskiy wrote: Hi Anthony, thank you for the review, seems like these lin

Re: [9] Review request for 7033533: realSync() doesn't work with Xfce

2014-01-24 Thread Oleg Pekhovskiy
Hi Anthony, thank you for the review, seems like these lines are redundant for two reasons: 1. We already have waiting cycle before these lines (2418-2429). 2. These lines are entered only on XConvertSelection failure with simple X Server (for example when the main Window Manager is crashed or

Re: [9] Review request for 7033533: realSync() doesn't work with Xfce

2014-01-24 Thread Anthony Petrov
Hi Oleg, Thanks for the update. The new version of the fix looks good to me. I'm wondering if we should preserve the workaround at original lines 2430-2442 in XToolkit.java for added safety? -- best regards, Anthony On 1/22/2014 8:31 PM, Oleg Pekhovskiy wrote: Hi Team, There was a long br

[9] Review request for 7033533: realSync() doesn't work with Xfce

2014-01-22 Thread Oleg Pekhovskiy
Hi Team, There was a long break after last comment and now I'm able to continue discussion. Please review the second version of fix: http://cr.openjdk.java.net/~bagiras/7033533.2/ I investigated the order of different events and found that ConfigureNotify event goes through event queues (X S