Re: [9] Review request for 8014212: Robot captures black screen

2015-08-11 Thread Alexander Scherbatiy
The fix looks good to me. Thanks, Alexandr. On 8/3/2015 7:05 PM, Sergey Bylokhov wrote: Looks fine. On 28.07.15 15:49, Alexander Zvegintsev wrote: Hello Sergey, please see the updated version http://cr.openjdk.java.net/~azvegint/jdk/9/8014212/02/ GetPrimitiveArrayCritical() is used i

Re: [9] Review request for 8014212: Robot captures black screen

2015-08-03 Thread Sergey Bylokhov
Looks fine. On 28.07.15 15:49, Alexander Zvegintsev wrote: Hello Sergey, please see the updated version http://cr.openjdk.java.net/~azvegint/jdk/9/8014212/02/ GetPrimitiveArrayCritical() is used instead of manual array allocation. Thanks, Alexander. On 07/27/2015 08:35 PM, Alexander Zvegintsev

Re: [9] Review request for 8014212: Robot captures black screen

2015-07-28 Thread Alexander Zvegintsev
Hello Sergey, please see the updated version http://cr.openjdk.java.net/~azvegint/jdk/9/8014212/02/ GetPrimitiveArrayCritical() is used instead of manual array allocation. Thanks, Alexander. On 07/27/2015 08:35 PM, Alexander Zvegintsev wrote: Please see the updated version: http://cr.openjdk.

Re: [9] Review request for 8014212: Robot captures black screen

2015-07-27 Thread Alexander Zvegintsev
Please see the updated version: http://cr.openjdk.java.net/~azvegint/jdk/9/8014212/01/ robot makes shot of intersection of provided rectangle with root window. Old robot implementation works for negative x and y, but may return garbage outside of root window behavior, so it was updated too. S

Re: [9] Review request for 8014212: Robot captures black screen

2015-07-23 Thread Sergey Bylokhov
Hi, Alexander. I am not sure that an assumption that we should not make a screen shot if the x and y are negative is correct. I guess that we should take a screenshot of the intersection of the requested area and the display. Can you also check this comment in the TranslucentJAppletTest.java:

[9] Review request for 8014212: Robot captures black screen

2015-07-23 Thread Alexander Zvegintsev
Hello, please review the fix http://cr.openjdk.java.net/~azvegint/jdk/9/8014212/00 for the issue https://bugs.openjdk.java.net/browse/JDK-8014212 This fix trying to use gdk_pixbuf_get_from_drawable () [0] to capture screenshot(basic image data handling could be found here[1]). If it fails then