Re: [9] Review request for 8022810: Cannot list all the available display modes on Ubuntu linux in case of two screen devices

2016-06-21 Thread Sergey Bylokhov
On 21.06.16 12:09, Semyon Sadetsky wrote: This test has no sense for Xinerama until java supports mode changes for it. I have created a bug to migrate getDisplayMode() to the new xrandr api: https://bugs.openjdk.java.net/browse/JDK-8159953 I am worried since we updated the enumDisplayModes(), bu

Re: [9] Review request for 8022810: Cannot list all the available display modes on Ubuntu linux in case of two screen devices

2016-06-21 Thread Semyon Sadetsky
On 6/20/2016 3:48 PM, Sergey Bylokhov wrote: On 20.06.16 13:29, Semyon Sadetsky wrote: So can you confirm that after the fix the next code will work w/o exceptions? http://cr.openjdk.java.net/~serb/tmp/Test.java Yes, for the single screen configuration. This test has no use for multimonitor co

Re: [9] Review request for 8022810: Cannot list all the available display modes on Ubuntu linux in case of two screen devices

2016-06-20 Thread Sergey Bylokhov
On 20.06.16 13:29, Semyon Sadetsky wrote: So can you confirm that after the fix the next code will work w/o exceptions? http://cr.openjdk.java.net/~serb/tmp/Test.java Yes, for the single screen configuration. This test has no use for multimonitor config because display mode change is not support

Re: [9] Review request for 8022810: Cannot list all the available display modes on Ubuntu linux in case of two screen devices

2016-06-20 Thread Semyon Sadetsky
On 6/7/2016 7:06 PM, Sergey Bylokhov wrote: On 01.06.16 9:57, Semyon Sadetsky wrote: I don't have access to such hardware as well. I'm using linux VMs with several virtual screens. Adding a new screen to a VM configuration can be done in 10 seconds in most VMMs. The result of the getDisplayMode

Re: [9] Review request for 8022810: Cannot list all the available display modes on Ubuntu linux in case of two screen devices

2016-06-07 Thread Sergey Bylokhov
On 01.06.16 9:57, Semyon Sadetsky wrote: I don't have access to such hardware as well. I'm using linux VMs with several virtual screens. Adding a new screen to a VM configuration can be done in 10 seconds in most VMMs. The result of the getDisplayModes() for 2-screen Ubuntu VM before the fix look

Re: [9] Review request for 8022810: Cannot list all the available display modes on Ubuntu linux in case of two screen devices

2016-05-31 Thread Semyon Sadetsky
On 5/31/2016 6:54 PM, Sergey Bylokhov wrote: On 31.05.16 18:49, Semyon Sadetsky wrote: Can you please provide the output of the test from the CR before/after the fix on your system? it is not necessary. You can run the provided test before and the fix and see that the list returned by getDisp

Re: [9] Review request for 8022810: Cannot list all the available display modes on Ubuntu linux in case of two screen devices

2016-05-31 Thread Sergey Bylokhov
On 31.05.16 18:49, Semyon Sadetsky wrote: Can you please provide the output of the test from the CR before/after the fix on your system? it is not necessary. You can run the provided test before and the fix and see that the list returned by getDisplayModes() is identical to xrandr output for any

Re: [9] Review request for 8022810: Cannot list all the available display modes on Ubuntu linux in case of two screen devices

2016-05-31 Thread Semyon Sadetsky
On 5/31/2016 6:22 PM, Sergey Bylokhov wrote: On 31.05.16 18:05, Semyon Sadetsky wrote: On 5/31/2016 5:18 PM, Sergey Bylokhov wrote: On 31.05.16 17:09, Semyon Sadetsky wrote: This is not true. Current mode is returned for screen > 0 Does it mean that this part in the description is incorr

Re: [9] Review request for 8022810: Cannot list all the available display modes on Ubuntu linux in case of two screen devices

2016-05-31 Thread Sergey Bylokhov
On 31.05.16 18:05, Semyon Sadetsky wrote: On 5/31/2016 5:18 PM, Sergey Bylokhov wrote: On 31.05.16 17:09, Semyon Sadetsky wrote: This is not true. Current mode is returned for screen > 0 Does it mean that this part in the description is incorrect? it depends on the OS and its configuration

Re: [9] Review request for 8022810: Cannot list all the available display modes on Ubuntu linux in case of two screen devices

2016-05-31 Thread Semyon Sadetsky
On 5/31/2016 5:18 PM, Sergey Bylokhov wrote: On 31.05.16 17:09, Semyon Sadetsky wrote: This is not true. Current mode is returned for screen > 0 Does it mean that this part in the description is incorrect? it depends on the OS and its configuration I guess. For Ubuntu 14/15 and OEL 6/7 it i

Re: [9] Review request for 8022810: Cannot list all the available display modes on Ubuntu linux in case of two screen devices

2016-05-31 Thread Sergey Bylokhov
On 31.05.16 17:09, Semyon Sadetsky wrote: This is not true. Current mode is returned for screen > 0 Does it mean that this part in the description is incorrect? Compile and run it on a system with two displays. Here is output when both display are switched on (note

Re: [9] Review request for 8022810: Cannot list all the available display modes on Ubuntu linux in case of two screen devices

2016-05-31 Thread Semyon Sadetsky
On 5/31/2016 4:53 PM, Sergey Bylokhov wrote: On 31.05.16 0:21, Semyon Sadetsky wrote: setDisplayMode() has been working if Xinerama is off. When Xinerama is on it could not set some modes for the screen 0 if there were incompatible modes from other screens in the list, and for all other screens

Re: [9] Review request for 8022810: Cannot list all the available display modes on Ubuntu linux in case of two screen devices

2016-05-31 Thread Sergey Bylokhov
On 31.05.16 0:21, Semyon Sadetsky wrote: setDisplayMode() has been working if Xinerama is off. When Xinerama is on it could not set some modes for the screen 0 if there were incompatible modes from other screens in the list, and for all other screens there were no modes. I am talking about Xine

Re: [9] Review request for 8022810: Cannot list all the available display modes on Ubuntu linux in case of two screen devices

2016-05-30 Thread Semyon Sadetsky
On 5/30/2016 8:35 PM, Sergey Bylokhov wrote: On 30.05.16 20:24, Semyon Sadetsky wrote: Will all these new display modes be accepted by the GraphicsDevice.setDisplayMode(dm)? Also please confirm that the new modes include the mode returned from GraphicsDevice.getDisplayMode(). The bug was file

Re: [9] Review request for 8022810: Cannot list all the available display modes on Ubuntu linux in case of two screen devices

2016-05-30 Thread Sergey Bylokhov
On 30.05.16 20:24, Semyon Sadetsky wrote: Will all these new display modes be accepted by the GraphicsDevice.setDisplayMode(dm)? Also please confirm that the new modes include the mode returned from GraphicsDevice.getDisplayMode(). The bug was filed against the getDisplayModes(). The setDisplayM

Re: [9] Review request for 8022810: Cannot list all the available display modes on Ubuntu linux in case of two screen devices

2016-05-30 Thread Semyon Sadetsky
On 5/30/2016 8:07 PM, Sergey Bylokhov wrote: Hi, Semyon. Will all these new display modes be accepted by the GraphicsDevice.setDisplayMode(dm)? Also please confirm that the new modes include the mode returned from GraphicsDevice.getDisplayMode(). The bug was filed against the getDisplayModes(

Re: [9] Review request for 8022810: Cannot list all the available display modes on Ubuntu linux in case of two screen devices

2016-05-30 Thread Sergey Bylokhov
Hi, Semyon. Will all these new display modes be accepted by the GraphicsDevice.setDisplayMode(dm)? Also please confirm that the new modes include the mode returned from GraphicsDevice.getDisplayMode(). On 27.05.16 14:25, Alexandr Scherbatiy wrote: On 5/13/2016 9:53 AM, Semyon Sadetsky wrote:

Re: [9] Review request for 8022810: Cannot list all the available display modes on Ubuntu linux in case of two screen devices

2016-05-27 Thread Alexandr Scherbatiy
The fix looks good to me. Thanks, Alexandr. On 5/13/2016 9:53 AM, Semyon Sadetsky wrote: Hello, Please review fix for JDK9: bug: https://bugs.openjdk.java.net/browse/JDK-8022810 webrev: http://cr.openjdk.java.net/~ssadetsky/8022810/webrev.00/ Xrandr's XRRGetScreenInfo cannot be used to get d

[9] Review request for 8022810: Cannot list all the available display modes on Ubuntu linux in case of two screen devices

2016-05-12 Thread Semyon Sadetsky
Hello, Please review fix for JDK9: bug: https://bugs.openjdk.java.net/browse/JDK-8022810 webrev: http://cr.openjdk.java.net/~ssadetsky/8022810/webrev.00/ Xrandr's XRRGetScreenInfo cannot be used to get display modes in case of Xinerama because there are no root windows for individual screens.