Re: [9] Review request for 8149115: [hidpi] Linux: display-wise scaling factor should probably be taken into account

It is unclear why gdk_scale is applied on top of native scale? So if both GDK_SCALE and scale-factor are set, then we will get the multiply of them, is it expected? On 08.07.16 13:27, Alexander Zvegintsev wrote: +1 On 7/8/16 10:37 AM, Alexandr Scherbatiy wrote: The fix looks good to me.

Re: [9] Review request for 8149115: [hidpi] Linux: display-wise scaling factor should probably be taken into account

+1 On 7/8/16 10:37 AM, Alexandr Scherbatiy wrote: The fix looks good to me. Thanks, Alexandr. On 7/8/2016 9:25 AM, Semyon Sadetsky wrote: I have changed variables declaration style in systemScale.c, because it produced warnings in Solaris build.

Re: [9] Review request for 8149115: [hidpi] Linux: display-wise scaling factor should probably be taken into account

The fix looks good to me. Thanks, Alexandr. On 7/8/2016 9:25 AM, Semyon Sadetsky wrote: I have changed variables declaration style in systemScale.c, because it produced warnings in Solaris build. http://cr.openjdk.java.net/~ssadetsky/8149115/webrev.03/ --Semyon On 7/7/2016 9:57 AM,

Re: [9] Review request for 8149115: [hidpi] Linux: display-wise scaling factor should probably be taken into account

I have changed variables declaration style in systemScale.c, because it produced warnings in Solaris build. http://cr.openjdk.java.net/~ssadetsky/8149115/webrev.03/ --Semyon On 7/7/2016 9:57 AM, Alexandr Scherbatiy wrote: The fix looks good to me. Thanks, Alexandr. On 7/6/2016 11:46 PM,

Re: [9] Review request for 8149115: [hidpi] Linux: display-wise scaling factor should probably be taken into account

The fix looks good to me. Thanks, Alexandr. On 7/6/2016 11:46 PM, Alexander Zvegintsev wrote: Still looks good. -- Thanks, Alexander. On 06.07.2016 21:42, Semyon Sadetsky wrote: Thanks, Alexander. Please see the updated webrev http://cr.openjdk.java.net/~ssadetsky/8149115/webrev.02/

Re: [9] Review request for 8149115: [hidpi] Linux: display-wise scaling factor should probably be taken into account

Still looks good. -- Thanks, Alexander. On 06.07.2016 21:42, Semyon Sadetsky wrote: Thanks, Alexander. Please see the updated webrev http://cr.openjdk.java.net/~ssadetsky/8149115/webrev.02/ --Semyon On 7/6/2016 9:03 PM, Alexander Zvegintsev wrote: The fix looks good to me. Just a minor

Re: [9] Review request for 8149115: [hidpi] Linux: display-wise scaling factor should probably be taken into account

Thanks, Alexander. Please see the updated webrev http://cr.openjdk.java.net/~ssadetsky/8149115/webrev.02/ --Semyon On 7/6/2016 9:03 PM, Alexander Zvegintsev wrote: The fix looks good to me. Just a minor comment: multiple NULL checks in get_schema_value could be wrapped in CHECK_NULL_RETURN

Re: [9] Review request for 8149115: [hidpi] Linux: display-wise scaling factor should probably be taken into account

The fix looks good to me. Just a minor comment: multiple NULL checks in get_schema_value could be wrapped in CHECK_NULL_RETURN macro, e.g.: CHECH_NULL_RETURN(fp_g_settings_schema_has_key = dlsym(lib_handle, "g_settings_schema_has_key"), NULL);

Re: [9] Review request for 8149115: [hidpi] Linux: display-wise scaling factor should probably be taken into account

The fix looks good to me. Thanks, Alexandr. On 7/6/2016 4:46 PM, Semyon Sadetsky wrote: On 7/6/2016 12:26 PM, Alexandr Scherbatiy wrote: On 7/5/2016 9:59 PM, Semyon Sadetsky wrote: Hello, Please review fix for JDK9: bug: https://bugs.openjdk.java.net/browse/JDK-8149115 webrev:

Re: [9] Review request for 8149115: [hidpi] Linux: display-wise scaling factor should probably be taken into account

On 7/5/2016 9:59 PM, Semyon Sadetsky wrote: Hello, Please review fix for JDK9: bug: https://bugs.openjdk.java.net/browse/JDK-8149115 webrev: http://cr.openjdk.java.net/~ssadetsky/8149115/webrev.00/ Currently the hidpi support on linux only reads GDK_SCALE environment variable to get the