Re: [9] Review request for 8153512: Taskbar support reported for Xfce4.

2016-07-13 Thread Alexandr Scherbatiy
The fix looks good to me. Thanks, Alexandr. On 7/12/2016 6:04 PM, Semyon Sadetsky wrote: Looks good to me. --Semyon On 12.07.2016 17:42, Alexander Zvegintsev wrote: Hi Semyon, please see the updated webrev http://cr.openjdk.java.net/~azvegint/jdk/9/8153512/01/ Thanks, Alexander. On 07/12/

Re: [9] Review request for 8153512: Taskbar support reported for Xfce4.

2016-07-12 Thread Semyon Sadetsky
Looks good to me. --Semyon On 12.07.2016 17:42, Alexander Zvegintsev wrote: Hi Semyon, please see the updated webrev http://cr.openjdk.java.net/~azvegint/jdk/9/8153512/01/ Thanks, Alexander. On 07/12/2016 05:22 PM, Semyon Sadetsky wrote: Hi Alexander, I would use a static variable and chec

Re: [9] Review request for 8153512: Taskbar support reported for Xfce4.

2016-07-12 Thread Alexander Zvegintsev
Hi Semyon, please see the updated webrev http://cr.openjdk.java.net/~azvegint/jdk/9/8153512/01/ Thanks, Alexander. On 07/12/2016 05:22 PM, Semyon Sadetsky wrote: Hi Alexander, I would use a static variable and check it once only. --Semyon On 12.07.2016 16:56, Alexander Zvegintsev wrote: He

Re: [9] Review request for 8153512: Taskbar support reported for Xfce4.

2016-07-12 Thread Semyon Sadetsky
Hi Alexander, I would use a static variable and check it once only. --Semyon On 12.07.2016 16:56, Alexander Zvegintsev wrote: Hello, please review the fix http://cr.openjdk.java.net/~azvegint/jdk/9/8153512/00/ for the issue https://bugs.openjdk.java.net/browse/JDK-8153512

[9] Review request for 8153512: Taskbar support reported for Xfce4.

2016-07-12 Thread Alexander Zvegintsev
Hello, please review the fix http://cr.openjdk.java.net/~azvegint/jdk/9/8153512/00/ for the issue https://bugs.openjdk.java.net/browse/JDK-8153512 -- Thanks, Alexander.