Re: [9] Review request for 8154434: Open the request focus methods of the java.awt.Component which accept FocusEvent.Cause

2016-10-20 Thread Anton Tarasov
Hi all, The changes look fine to me. On 4/26/2016 3:49 PM, Philip Race wrote: > In applications one may need to know the reason why focus is requested I do not mean why should apps want to *know* the cause. I am asking why apps should be able to *specify* the cause as proposed by this

Re: [9] Review request for 8154434: Open the request focus methods of the java.awt.Component which accept FocusEvent.Cause

2016-09-23 Thread Alexander Zvegintsev
Looks good to me. -- Thanks, Alexander. On 26.04.2016 16:14, Semyon Sadetsky wrote: On 4/26/2016 3:49 PM, Philip Race wrote: > In applications one may need to know the reason why focus is requested I do not mean why should apps want to *know* the cause. I am asking why apps should be able

Re: [9] Review request for 8154434: Open the request focus methods of the java.awt.Component which accept FocusEvent.Cause

2016-04-26 Thread Philip Race
> In applications one may need to know the reason why focus is requested I do not mean why should apps want to *know* the cause. I am asking why apps should be able to *specify* the cause as proposed by this change. Being "symmetric" is not a sufficient reason. -phil. On 4/26/16, 12:27 AM,

Re: [9] Review request for 8154434: Open the request focus methods of the java.awt.Component which accept FocusEvent.Cause

2016-04-26 Thread Semyon Sadetsky
On 4/25/2016 10:33 PM, Phil Race wrote: You will need to convince me of the appropriateness of opening these methods. It seems to me that are for the focus system, not for applications. Why should an application be allowed to say "I would like component X" to receive focus and tell it the

[9] Review request for 8154434: Open the request focus methods of the java.awt.Component which accept FocusEvent.Cause

2016-04-19 Thread Semyon Sadetsky
Hello, Please review fix for JDK9: bug: https://bugs.openjdk.java.net/browse/JDK-8154434 webrev: http://cr.openjdk.java.net/~ssadetsky/8154434/webrev.00/ To support the new FocusEvent cause concept introduced by JDK-8080395 the next package-private methods of the java.awt.Component class are