Re: [9] Review request for 8166594: Taskbar.setWindowProgressValue() spec does not specify expected visual behavior of setWindowProgressValue()

2016-10-18 Thread Sergey Bylokhov
+1 I also suggest to file a bug to specify "null" behavior for the new methods. In some cases we already do this, in some not. On 18.10.16 14:15, Semyon Sadetsky wrote: +1 --Semyon On 18.10.2016 14:13, Alexander Zvegintsev wrote: Updated the "behavior is undefined" section: http://cr.open

Re: [9] Review request for 8166594: Taskbar.setWindowProgressValue() spec does not specify expected visual behavior of setWindowProgressValue()

2016-10-18 Thread Semyon Sadetsky
+1 --Semyon On 18.10.2016 14:13, Alexander Zvegintsev wrote: Updated the "behavior is undefined" section: http://cr.openjdk.java.net/~azvegint/jdk/9/8166594/01/ Thanks, Alexander. On 10/6/16 6:14 PM, Semyon Sadetsky wrote: On 10/6/2016 3:38 PM, Alexander Zvegintsev wrote: Hi Semyon, Yes

Re: [9] Review request for 8166594: Taskbar.setWindowProgressValue() spec does not specify expected visual behavior of setWindowProgressValue()

2016-10-18 Thread Alexander Zvegintsev
Updated the "behavior is undefined" section: http://cr.openjdk.java.net/~azvegint/jdk/9/8166594/01/ Thanks, Alexander. On 10/6/16 6:14 PM, Semyon Sadetsky wrote: On 10/6/2016 3:38 PM, Alexander Zvegintsev wrote: Hi Semyon, Yes it is, Microsoft defined some set of rules for such case[0]. Ho

Re: [9] Review request for 8166594: Taskbar.setWindowProgressValue() spec does not specify expected visual behavior of setWindowProgressValue()

2016-10-06 Thread Semyon Sadetsky
On 10/6/2016 3:38 PM, Alexander Zvegintsev wrote: Hi Semyon, Yes it is, Microsoft defined some set of rules for such case[0]. However it looks redundant and too implementation-specific(which can be changed) for me. I didn't mean to specify the behavior for Windows platform. It seems that any

Re: [9] Review request for 8166594: Taskbar.setWindowProgressValue() spec does not specify expected visual behavior of setWindowProgressValue()

2016-10-06 Thread Alexander Zvegintsev
Hi Semyon, Yes it is, Microsoft defined some set of rules for such case[0]. However it looks redundant and too implementation-specific(which can be changed) for me. Reformatted for 80 chars in place. [0] https://msdn.microsoft.com/en-us/library/windows/desktop/dd391698(v=vs.85).aspx#How_th

Re: [9] Review request for 8166594: Taskbar.setWindowProgressValue() spec does not specify expected visual behavior of setWindowProgressValue()

2016-10-05 Thread Semyon Sadetsky
Hi Alexander, 416 * Note that the behavior is undefined when multiple windows is grouped in the task area. Isn't the above a some kind of simplification? Could you reformat changed lines to make them following the 80 chars maximum? --Semyon On 06.10.2016 04:56, Alexander Zvegintsev

[9] Review request for 8166594: Taskbar.setWindowProgressValue() spec does not specify expected visual behavior of setWindowProgressValue()

2016-10-05 Thread Alexander Zvegintsev
Hello, please review the fix http://cr.openjdk.java.net/~azvegint/jdk/9/8166594/00/ for the issue https://bugs.openjdk.java.net/browse/JDK-8166594 It also fixes two issues to conform the documentation: setting value below 0 doesn't disable progress indication switching from indeterminate t