Re: [9] Review request for 8167652: Making a frame/dialog resizeble/unresizeble shifts its position on Unity.

2016-12-19 Thread Sergey Bylokhov
+1 > > Looks good to me. > > Thanks, > Alexander. > > On 26/10/2016 16:06, Semyon Sadetsky wrote: >> Please review the updated fix: >> http://cr.openjdk.java.net/~ssadetsky/8167652/webrev.01/ >> >> - unnecessary AWT locks are removed >> >> - client code calls are taken away from AWT lock

Re: [9] Review request for 8167652: Making a frame/dialog resizeble/unresizeble shifts its position on Unity.

2016-10-26 Thread Semyon Sadetsky
Please review the updated fix: http://cr.openjdk.java.net/~ssadetsky/8167652/webrev.01/ - unnecessary AWT locks are removed - client code calls are taken away from AWT lock blocks - some design improvements are made --Semyon On 10/19/2016 8:38 PM, Sergey Bylokhov wrote: Hi, Semyon. A few

Re: [9] Review request for 8167652: Making a frame/dialog resizeble/unresizeble shifts its position on Unity.

2016-10-19 Thread Sergey Bylokhov
Hi, Semyon. A few notes. - The awtLock is a lowlevel lock which should be used only when we access the xlib and some other native resource like opengl. We should not call the users code on it. In the fix the code in XDecoratedPeer.updateMinimumSize() will call the users code. - Some of the

[9] Review request for 8167652: Making a frame/dialog resizeble/unresizeble shifts its position on Unity.

2016-10-18 Thread Semyon Sadetsky
Hello, Please review fix for JDK9: bug: https://bugs.openjdk.java.net/browse/JDK-8167652 webrev: http://cr.openjdk.java.net/~ssadetsky/8167652/webrev.00/ In Linux, when a frame or dilalog is made resizable or non-resizable the window decoration need to be updated. For that purpose window is