Re: [9] Review request for 8176528: Progress state for window is not displayed in taskbar

Looks fine. > 15 марта 2017 г., в 20:49, Philip Race написал(а): > > +1 from me. > > -phil. > > On 3/15/17, 10:47 AM, Alexander Zvegintsev wrote: >> >> How about that version? >> >> http://cr.openjdk.java.net/~azvegint/jdk/9/8176528/04/ >>

Re: [9] Review request for 8176528: Progress state for window is not displayed in taskbar

+1 from me. -phil. On 3/15/17, 10:47 AM, Alexander Zvegintsev wrote: How about that version? http://cr.openjdk.java.net/~azvegint/jdk/9/8176528/04/ Thanks, Alexander. On 15/03/2017 20:18, Philip Race wrote: Even if all we can add (to what is already proposed) is "whether an icon for a wind

Re: [9] Review request for 8176528: Progress state for window is not displayed in taskbar

How about that version? http://cr.openjdk.java.net/~azvegint/jdk/9/8176528/04/ Thanks, Alexander. On 15/03/2017 20:18, Philip Race wrote: Even if all we can add (to what is already proposed) is "whether an icon for a window is displayable in the task bar is dependent on all of window type, pl

Re: [9] Review request for 8176528: Progress state for window is not displayed in taskbar

Even if all we can add (to what is already proposed) is "whether an icon for a window is displayable in the task bar is dependent on all of window type, platform, and implementation" then I think that clearer than the current words which could be misinterpreted as meaning something like addressin

Re: [9] Review request for 8176528: Progress state for window is not displayed in taskbar

It is not necessary, if the frame has utility type. >>> >>> So can we say this with that qualification ? >> >> This is also implementation detail, that such windows are not visible in >> taskbar. This is not specified anywhere and can be changed in the future. > > If this is consistent in

Re: [9] Review request for 8176528: Progress state for window is not displayed in taskbar

On 3/15/17, 9:48 AM, Sergey Bylokhov wrote: The current fix isn't even "general" in this respect. Unless there are some existing words somewhere, in which case we would just have pointed JCK to those .. All this stuff have a notion that «xxx in a platform-dependent way.». The only things we

Re: [9] Review request for 8176528: Progress state for window is not displayed in taskbar

> The current fix isn't even "general" in this respect. > Unless there are some existing words somewhere, in > which case we would just have pointed JCK to those .. All this stuff have a notion that «xxx in a platform-dependent way.». The only things we can say is that we will try to show a some

Re: [9] Review request for 8176528: Progress state for window is not displayed in taskbar

The current fix isn't even "general" in this respect. Unless there are some existing words somewhere, in which case we would just have pointed JCK to those .. On 3/15/17, 9:12 AM, Sergey Bylokhov wrote: I guess that we cannot guarantee that some windows are visible and other one are not. We can

Re: [9] Review request for 8176528: Progress state for window is not displayed in taskbar

I guess that we cannot guarantee that some windows are visible and other one are not. We can say something general like in the current fix, or we can provide an explanation of our internal implementation. > 15 марта 2017 г., в 18:49, Philip Race написал(а): > > Good that got cleared up but sin

Re: [9] Review request for 8176528: Progress state for window is not displayed in taskbar

Good that got cleared up but since bar slight change in the wording we are back to v0 of the webrev, then we are also back to v0 of my comments. What are you going to say to JCK about what windows they can expect to be visible ? Can we say - Frames are always visible - Dialogs are always visible

Re: [9] Review request for 8176528: Progress state for window is not displayed in taskbar

It turned out that if Dialog has no owner(e.g. new Dialog((Frame) null)) it is visible in the taskbar. So I am reverting API change. http://cr.openjdk.java.net/~azvegint/jdk/9/8176528/03/ Thanks, Alexander. On 14/03/2017 23:43, Alexander Zvegintsev wrote: It has no representation on windows,

Re: [9] Review request for 8176528: Progress state for window is not displayed in taskbar

It has no representation on windows, but I assume it can have such on other platforms like OSX/Unity? OSX/Unity functionality doesn't have per window concept, they have per application. For these operating system you should use setProgressValue() instead of setWindowProgressValue()(and so on).

Re: [9] Review request for 8176528: Progress state for window is not displayed in taskbar

It has no representation on windows, but I assume it can have such on other platforms like OSX/Unity? > It is fine too, because Dialog has no representation in the taskbar too. We also exclude JWindow. > > -- > Thanks, > Alexander. > > On 14.03.2017 15:56, Philip Race wrote: >> Hi, >> >> I r

Re: [9] Review request for 8176528: Progress state for window is not displayed in taskbar

OK. So this API change seems like a necessary one. -phil. On 3/14/17, 6:09 AM, Alexander Zvegintsev wrote: It is fine too, because Dialog has no representation in the taskbar too. -- Thanks, Alexander. On 14.03.2017 15:56, Philip Race wrote: Hi, I realise I need to clarify one thing that ma

Re: [9] Review request for 8176528: Progress state for window is not displayed in taskbar

It is fine too, because Dialog has no representation in the taskbar too. -- Thanks, Alexander. On 14.03.2017 15:56, Philip Race wrote: Hi, I realise I need to clarify one thing that may be important. Previously with Window this could apply to a Dialog. Now it cannot. Are we disabling an import

Re: [9] Review request for 8176528: Progress state for window is not displayed in taskbar

Hi, I realise I need to clarify one thing that may be important. Previously with Window this could apply to a Dialog. Now it cannot. Are we disabling an important case with this change ? -phil On 3/14/17, 5:54 AM, Alexander Zvegintsev wrote: There is no precedents here: http://cr.openjdk.java

Re: [9] Review request for 8176528: Progress state for window is not displayed in taskbar

There is no precedents here: http://cr.openjdk.java.net/~azvegint/jdk/9/8176528/02/ Thanks, Alexander. On 14/03/2017 15:40, Philip Race wrote: with this change maybe we should be renaming the parameters and update the doc ie 279 * @param w window could be @param f frame ? Or is there pr

Re: [9] Review request for 8176528: Progress state for window is not displayed in taskbar

with this change maybe we should be renaming the parameters and update the doc ie 279 * @param w window could be @param f frame ? Or is there precedent for what you have right now ? -phil. On 3/14/17, 5:33 AM, Alexander Zvegintsev wrote: So they already know the window isn't visible and

Re: [9] Review request for 8176528: Progress state for window is not displayed in taskbar

So they already know the window isn't visible and are asking for an explanation of the circumstances for this so I don't think this update will satisfy them without more explanation. At the very least we need to add that "Some {@code Window}s are not visible in the task bar. For example undecor

Re: [9] Review request for 8176528: Progress state for window is not displayed in taskbar

The JCK comments in the bug are : >This may be a specification issue. >Window progress is not displayed in taskbar as specified. >The spec states that progress is displayed in a platform-dependent way. I>f progress is not in fact displayed under some circumstances, that should be specified. So

[9] Review request for 8176528: Progress state for window is not displayed in taskbar

Hello, please review the fix http://cr.openjdk.java.net/~azvegint/jdk/9/8176528/00/ for the issue https://bugs.openjdk.java.net/browse/JDK-8176528 The test uses java.awt.Window which doesn't have button for its window in the taskbar, thus we can't show progress for this window there. --