Re: [9] Review request for 8177919: java.awt.Desktop.setDefaultMenuBar​() should be specified to throw IllegalStateException

2017-04-13 Thread Alexander Zvegintsev
No, it doesn't fix the issue, behavior remains as before the fix. I've filed it yesterday: https://bugs.openjdk.java.net/browse/JDK-8178448 Thanks, Alexander. On 13/04/2017 22:43, Sergey Bylokhov wrote: Hi, Alex. Are these changes fix the bug which we talked offline(you planned to file it se

Re: [9] Review request for 8177919: java.awt.Desktop.setDefaultMenuBar​() should be specified to throw IllegalStateException

2017-04-13 Thread Sergey Bylokhov
Hi, Alex. Are these changes fix the bug which we talked offline(you planned to file it separatly)? - alexander.zvegint...@oracle.com wrote: > Actually it does nothing on Windows and Linux. > > Please review another version of the fix, > > it enables default menubar regardless of apple.laf.

Re: [9] Review request for 8177919: java.awt.Desktop.setDefaultMenuBar​() should be specified to throw IllegalStateException

2017-04-13 Thread Alexander Zvegintsev
Sure, I've updated it in place, javax.swing.* wild card import replaced as well. CCC request is also submitted. Thanks, Alexander. On 13/04/2017 20:46, Phil Race wrote: 28 import java.awt.*; Could this be just "import java.awt.Container;" ? Other than that this seems fine with the proviso tha

Re: [9] Review request for 8177919: java.awt.Desktop.setDefaultMenuBar​() should be specified to throw IllegalStateException

2017-04-13 Thread Phil Race
28 import java.awt.*; Could this be just "import java.awt.Container;" ? Other than that this seems fine with the proviso that this has been tested with different L&Fs .. and even with none installed. -phil. On 04/13/2017 10:38 AM, Alexander Zvegintsev wrote: Actually it does nothing on Windo

Re: [9] Review request for 8177919: java.awt.Desktop.setDefaultMenuBar​() should be specified to throw IllegalStateException

2017-04-13 Thread Alexander Zvegintsev
Actually it does nothing on Windows and Linux. Please review another version of the fix, it enables default menubar regardless of apple.laf.useScreenMenuBar property and restores an old default MenuBarUI when it is used in JFrame. http://cr.openjdk.java.net/~azvegint/jdk/9/8177919/01/ Thank

Re: [9] Review request for 8177919: java.awt.Desktop.setDefaultMenuBar​() should be specified to throw IllegalStateException

2017-04-11 Thread Phil Race
I'd like to understand the big picture here Q1. What does this Desktop API do on Windows and Linux ? Q2. If someone calls this API it is pretty clear what they want. Why do we require that they be running Aqua when a lot of the requests were specifically about de-coupling it from

Re: [9] Review request for 8177919: java.awt.Desktop.setDefaultMenuBar​() should be specified to throw IllegalStateException

2017-04-11 Thread Semyon Sadetsky
+1 --Semyon On 04/11/2017 09:53 AM, Sergey Bylokhov wrote: Looks fine. Hello, please review the fix http://cr.openjdk.java.net/~azvegint/jdk/9/8177919/00/ for the issue https://bugs.openjdk.java.net/browse/JDK-8177919 This fix removes throwing of ISE, this allows to use default menu bar

Re: [9] Review request for 8177919: java.awt.Desktop.setDefaultMenuBar​() should be specified to throw IllegalStateException

2017-04-11 Thread Sergey Bylokhov
Looks fine. > > Hello, > > please review the fix > > http://cr.openjdk.java.net/~azvegint/jdk/9/8177919/00/ > > for the issue > > https://bugs.openjdk.java.net/browse/JDK-8177919 > > This fix removes throwing of ISE, this allows to use default menu bar with > LaF's other than Aqua (with app

[9] Review request for 8177919: java.awt.Desktop.setDefaultMenuBar​() should be specified to throw IllegalStateException

2017-04-11 Thread Alexander Zvegintsev
Hello, please review the fix http://cr.openjdk.java.net/~azvegint/jdk/9/8177919/00/ for the issue https://bugs.openjdk.java.net/browse/JDK-8177919 This fix removes throwing of ISE, this allows to use default menu bar with LaF's other than Aqua (with apple.laf.useScreenMenuBar set to true).