Re: [9] Review request for 8177919: java.awt.Desktop.setDefaultMenuBar​() should be specified to throw IllegalStateException

2017-04-13 Thread Sergey Bylokhov
Hi, Alex. Are these changes fix the bug which we talked offline(you planned to file it separatly)? - alexander.zvegint...@oracle.com wrote: > Actually it does nothing on Windows and Linux. > > Please review another version of the fix, > > it enables default menubar regardless of

Re: [9] Review request for 8177919: java.awt.Desktop.setDefaultMenuBar​() should be specified to throw IllegalStateException

2017-04-13 Thread Phil Race
28 import java.awt.*; Could this be just "import java.awt.Container;" ? Other than that this seems fine with the proviso that this has been tested with different L .. and even with none installed. -phil. On 04/13/2017 10:38 AM, Alexander Zvegintsev wrote: Actually it does nothing on Windows

Re: [9] Review request for 8177919: java.awt.Desktop.setDefaultMenuBar​() should be specified to throw IllegalStateException

2017-04-11 Thread Phil Race
I'd like to understand the big picture here Q1. What does this Desktop API do on Windows and Linux ? Q2. If someone calls this API it is pretty clear what they want. Why do we require that they be running Aqua when a lot of the requests were specifically about de-coupling it from

[9] Review request for 8177919: java.awt.Desktop.setDefaultMenuBar​() should be specified to throw IllegalStateException

2017-04-11 Thread Alexander Zvegintsev
Hello, please review the fix http://cr.openjdk.java.net/~azvegint/jdk/9/8177919/00/ for the issue https://bugs.openjdk.java.net/browse/JDK-8177919 This fix removes throwing of ISE, this allows to use default menu bar with LaF's other than Aqua (with apple.laf.useScreenMenuBar set to true).