Re: [9] Review request for JDK-8137137: [macosx] The native dialog doesn't have 'close'(X) button on Mac OS.

+1 -phil. On 04/19/2016 01:40 AM, prasanta sadhukhan wrote: Looks ok to me. Regards Prasanta On 4/19/2016 1:25 PM, Manajit Halder wrote: Hi Prasanta, Thank you for the review comments. Please review the updated webrev. http://cr.openjdk.java.net/~mhalder/8137137/webrev.02/

Re: [9] Review request for JDK-8137137: [macosx] The native dialog doesn't have 'close'(X) button on Mac OS.

Hi Phil, Gentle reminder. Please review the updated webrev http://cr.openjdk.java.net/~mhalder/8137137/webrev.02/ Thanks, Manajit > On 20-Apr-2016, at 6:03 pm, Manajit Halder wrote: > > Hi Phil, > > Gentle remainder. Please review the

Re: [9] Review request for JDK-8137137: [macosx] The native dialog doesn't have 'close'(X) button on Mac OS.

Hi Phil, Gentle remainder. Please review the changes. Thanks, Manajit > On 19-Apr-2016, at 2:10 pm, prasanta sadhukhan > wrote: > > Looks ok to me. > > Regards > Prasanta > On 4/19/2016 1:25 PM, Manajit Halder wrote: >> Hi Prasanta, >> >> Thank you for the review comments. Please review the

Re: [9] Review request for JDK-8137137: [macosx] The native dialog doesn't have 'close'(X) button on Mac OS.

Looks ok to me. Regards Prasanta On 4/19/2016 1:25 PM, Manajit Halder wrote: Hi Prasanta, Thank you for the review comments. Please review the updated webrev. http://cr.openjdk.java.net/~mhalder/8137137/webrev.02/ Regards, Manajit

Re: [9] Review request for JDK-8137137: [macosx] The native dialog doesn't have 'close'(X) button on Mac OS.

Hi Prasanta, Thank you for the review comments. Please review the updated webrev. http://cr.openjdk.java.net/~mhalder/8137137/webrev.02/ Regards, Manajit > On 18-Apr-2016, at 3:30 pm, prasanta sadhukhan > wrote: > > Hi Manajit. > > W

Re: [9] Review request for JDK-8137137: [macosx] The native dialog doesn't have 'close'(X) button on Mac OS.

Hi Manajit. While pressing x button , the test dialog is not closing in windows. Please check that. Also, the failure message /throw new RuntimeException("Updating TrayIcon popup menu"// //+ " items FAILED");// / seems to be wrong. Regards Prasanta On 4/18/2016 2:59 PM,

Re: [9] Review request for JDK-8137137: [macosx] The native dialog doesn't have 'close'(X) button on Mac OS.

Hi Phil, Thank you for the review comments. Please review the updated webrev. http://cr.openjdk.java.net/~mhalder/8137137/webrev.01/ Regards, Manajit > On 15-Apr-2016, at 11:39 pm, Phil Race wrote: > > Hi, > > Good to get rid of one a

Re: [9] Review request for JDK-8137137: [macosx] The native dialog doesn't have 'close'(X) button on Mac OS.

Hi, Good to get rid of one applet test. Only 1,499 to go :-) Even though you effectively re-wrote this you should set the (c) as a range "2007, 2016" Also I think we should try to use the natural size of the component rather than explicitly setting the size :- instructionFrame.setBounds(0, 0

[9] Review request for JDK-8137137: [macosx] The native dialog doesn't have 'close'(X) button on Mac OS.

Hi All, Kindly review the fix for JDK9. Bug: https://bugs.openjdk.java.net/browse/JDK-8137137 Webrev: http://cr.openjdk.java.net/~mhalder/8137137/webrev.00/ Issue: The native print d