Re: [9] Review request for JDK-8160266: [macosx] NestedModalDialogTest.java and NestedModelessDialogTest.java tests does not run with current JDK codebase after taking the files fro

2016-07-18 Thread Rajeev Chamyal
Looks fine to me. Regards, Rajeev Chamyal From: Alexandr Scherbatiy Sent: 14 July 2016 20:45 To: Manajit Halder Cc: awt-dev@openjdk.java.net; Avik Niyogi Subject: Re: [9] Review request for JDK-8160266: [macosx] NestedModalDialogTest.java and NestedModelessDialogTest.java tests does not

Re: [9] Review request for JDK-8160266: [macosx] NestedModalDialogTest.java and NestedModelessDialogTest.java tests does not run with current JDK codebase after taking the files fro

2016-07-14 Thread Alexandr Scherbatiy
The fix looks good to me. Thanks, Alexandr. On 7/12/2016 2:47 PM, Manajit Halder wrote: Hi Alexandr, Thank you for the review comments. Code is modified as per you suggestion. RobotUtilities class is replaced with direct calls to corresponding methods in Robot class and also Util class is us

Re: [9] Review request for JDK-8160266: [macosx] NestedModalDialogTest.java and NestedModelessDialogTest.java tests does not run with current JDK codebase after taking the files fro

2016-07-12 Thread Manajit Halder
Hi Alexandr, Thank you for the review comments. Code is modified as per you suggestion. RobotUtilities class is replaced with direct calls to corresponding methods in Robot class and also Util class is used in some places. Please review the modified code. http://cr.openjdk.java.net/~mhalder/816

Re: [9] Review request for JDK-8160266: [macosx] NestedModalDialogTest.java and NestedModelessDialogTest.java tests does not run with current JDK codebase after taking the files fro

2016-07-08 Thread Alexandr Scherbatiy
Is it possible to get rid of the RobotUtilities class? Methods like RobotUtilities.pressKey(int num)/releaseKey(int num) are just direct calls to the corresponding methods in Robot. Other necessary methods can be added to test/java/awt/regtesthelpers/Util.java Thanks, Alexandr. On 7/7/2016

Re: [9] Review request for JDK-8160266: [macosx] NestedModalDialogTest.java and NestedModelessDialogTest.java tests does not run with current JDK codebase after taking the files fro

2016-07-07 Thread Manajit Halder
Hi All, Gentle remainder. Please review the fix for issue https://bugs.openjdk.java.net/browse/JDK-8160266 . Thanks, Manajit > On 24-Jun-2016, at 8:53 pm, Manajit Halder wrote: > > Hi Sergey, > > Kindly review the fix for JDK9. > > Bug: >