m>
> Cc: Sergey Bylokhov <sergey.bylok...@oracle.com>; awt-
> d...@openjdk.java.net; 2d-dev <2d-...@openjdk.java.net>
> Subject: Re: [OpenJDK 2D-Dev] RFR(M): 8170525: Fix minor
> issues in awt coding
>
> I didn't eyeball what you changed but JPRT is now happy.
&
.@sap.com>; Sergey Bylokhov
<sergey.bylok...@oracle.com>
Cc: awt-dev@openjdk.java.net; 2d-dev<2d-...@openjdk.java.net>
Subject: Re: [OpenJDK 2D-Dev] RFR(M): 8170525: Fix minor
issues in awt coding
I tried it .. and just as well I did. It fails in the crypto code on Mac.
jdk/src/jd
02, 2016 8:46 PM
> >> To: Lindenmaier, Goetz <goetz.lindenma...@sap.com>; Sergey Bylokhov
> >> <sergey.bylok...@oracle.com>
> >> Cc: awt-dev@openjdk.java.net; 2d-dev <2d-...@openjdk.java.net>
> >> Subject: Re: [OpenJDK 2D-Dev] RFR(M): 8170525: F
]
Sent: Friday, December 02, 2016 8:46 PM
To: Lindenmaier, Goetz <goetz.lindenma...@sap.com>; Sergey Bylokhov
<sergey.bylok...@oracle.com>
Cc: awt-dev@openjdk.java.net; 2d-dev <2d-...@openjdk.java.net>
Subject: Re: [OpenJDK 2D-Dev] RFR(M): 8170525: Fix minor
issues in awt codi
;; Sergey Bylokhov
> <sergey.bylok...@oracle.com>
> Cc: awt-dev@openjdk.java.net; 2d-dev <2d-...@openjdk.java.net>
> Subject: Re: [OpenJDK 2D-Dev] RFR(M): 8170525: Fix minor
> issues in awt coding
>
> I had no other comments, except that it would be good to be sure
>
-...@openjdk.java.net>; security-
d...@openjdk.java.net
Subject: Re: [OpenJDK 2D-Dev] RFR(M): 8170525: Fix minor issues
in awt coding
Sorry. it is
ops->GetRasInfo(env, ops, lockInfo);
that initialises it ..
That is still before the dereference
Anyway, what was the reaso
r...@oracle.com>
> Cc: awt-dev@openjdk.java.net; 2d-dev <2d-...@openjdk.java.net>; security-
> d...@openjdk.java.net
> Subject: Re: [OpenJDK 2D-Dev] RFR(M): 8170525: Fix minor issues
> in awt coding
>
> Sorry. it is
> ops->GetRasInfo(env, ops, lockInfo);
> t
ava.net>; security-
d...@openjdk.java.net
Subject: Re: [OpenJDK 2D-Dev] RFR(M): 8170525: Fix minor issues
in awt coding
Hi Goetz,
DataBufferNative.c
Using uninitialized value lockInfo.rasBase when calling DBN_GetPixelPointer.
75 lockInfo.resBase = NULL;
Did you actually compi
ta Sadhukhan' <prasanta.sadhuk...@oracle.com>; Phil Race
> <philip.r...@oracle.com>; Sergey Bylokhov <sergey.bylok...@oracle.com>;
> Vincent Ryan <vincent.x.r...@oracle.com>
> Cc: awt-dev@openjdk.java.net; 2d-dev <2d-...@openjdk.java.net>; security-
> d...@openjdk.java.net
rgey.bylok...@oracle.com>; Lindenmaier, Goetz
> <goetz.lindenma...@sap.com>; Vincent Ryan <vincent.x.r...@oracle.com>
> Cc: awt-dev@openjdk.java.net; 2d-dev <2d-...@openjdk.java.net>; security-
> d...@openjdk.java.net
> Subject: Re: [OpenJDK 2D-Dev] RF
yes, this is a potential issue. But actually cases MID,FOCUS,BLACK,WHITE
are never used.
But the fix is wrong. It should be
color.alpha = 1; --Semyon
On 01.12.2016 08:05, Prasanta Sadhukhan wrote:
Also, in gtk3_interface.c, there is this change for color.alpha
2219 color.alpha = 0; in
Also, in gtk3_interface.c, there is this change for color.alpha
2219 color.alpha = 0; in gtk3_get_color_for_flags()
but it is used in
gtk3_get_color_for_state() where it is not initialized
2268 GdkRGBA color;
Regards
Prasanta
On 12/1/2016 1:28 AM, Phil Race wrote:
Hi Goetz,
Hi Goetz,
DataBufferNative.c
Using uninitialized value lockInfo.rasBase when calling DBN_GetPixelPointer.
75 lockInfo.resBase = NULL;
Did you actually compile this ? The variable is called "rasBase", not
"resBase".
And strictly there is no problem since inside DBN_GetPixelPointer
13 matches
Mail list logo
