still looks good to me.
Thanks,
Alexander.
On 07/15/2015 03:59 PM, Semyon Sadetsky wrote:
Hi Alexander,
In the next version I have updated the test and Sergey's notes are
taken into account.
http://cr.openjdk.java.net/~ssadetsky/8025815/webrev.01/
--Semyon
On 7/13/2015 7:21 PM, Alexander
Hi Alexander,
In the next version I have updated the test and Sergey's notes are taken
into account.
http://cr.openjdk.java.net/~ssadetsky/8025815/webrev.01/
--Semyon
On 7/13/2015 7:21 PM, Alexander Zvegintsev wrote:
Hello Semyon,
the fix itself look good to me, but the test seems to be br
The fix is stable.
On 7/14/2015 3:02 PM, Sergey Bylokhov wrote:
On 14.07.15 14:16, Semyon Sadetsky wrote:
This is concurrency issue. Such test would be unstable or take a lot
of time.
I guess after the fix it should be stable? or there are some other
issues?
On 7/14/2015 1:08 PM, Sergey By
On 14.07.15 14:16, Semyon Sadetsky wrote:
This is concurrency issue. Such test would be unstable or take a lot
of time.
I guess after the fix it should be stable? or there are some other issues?
On 7/14/2015 1:08 PM, Sergey Bylokhov wrote:
On 13.07.15 16:59, Semyon Sadetsky wrote:
Yet anothe
This is concurrency issue. Such test would be unstable or take a lot of
time.
On 7/14/2015 1:08 PM, Sergey Bylokhov wrote:
On 13.07.15 16:59, Semyon Sadetsky wrote:
Yet another issue I found in the GTK file chooser code is a dispose
concurrency issue. The GTK dialog widget is being created in
Small comment:
GtkFileDialogPeer.c: you will need to add a CHECK_NULL( widgetFieldID)
before setWindowMethodID, and CHECK_NULL(setWindowMethodID); at the end
of the method is not necessary.
On 13.07.15 16:59, Semyon Sadetsky wrote:
Hello,
Please review fix for JDK9:
bug: https://bugs.openjd
On 13.07.15 16:59, Semyon Sadetsky wrote:
Yet another issue I found in the GTK file chooser code is a dispose
concurrency issue. The GTK dialog widget is being created in a
separate thread upon the setVisible(true) call but it can be hidden or
disposed without any synchronization with this thre
Hello Semyon,
the fix itself look good to me, but the test seems to be broken, it
passes for me before the fix and fails after( Ubuntu 14.04, Unity)
Thanks,
Alexander.
On 07/13/2015 04:59 PM, Semyon Sadetsky wrote:
Hello,
Please review fix for JDK9:
bug: https://bugs.openjdk.java.net/brow
Hello,
Please review fix for JDK9:
bug: https://bugs.openjdk.java.net/browse/JDK-8025815
wbrev: http://cr.openjdk.java.net/~ssadetsky/8025815/webrev.00/
The root cause is a mixing of GTK and XLib windows. Normally Java uses
XLib windows and manage focus transitivity on its side. But for the fi
