Re: [9] Review Request for 8141528: Test closed/java/awt/FullScreen/DisplayMode/CycleDMImage.java fails for Ubuntu 15.10

2016-10-05 Thread Semyon Sadetsky
On 05.10.2016 01:53, Sergey Bylokhov wrote: On 04.10.16 16:27, Semyon Sadetsky wrote: On 10/4/2016 4:05 PM, Sergey Bylokhov wrote: Hi, Semyon. - It seems that DisplayMode contain the data which were not upscaled to the units instead of pixels. It seems incorrect that it is necessary to

Re: [9] Review Request for 8141528: Test closed/java/awt/FullScreen/DisplayMode/CycleDMImage.java fails for Ubuntu 15.10

2016-10-04 Thread Sergey Bylokhov
On 04.10.16 16:27, Semyon Sadetsky wrote: On 10/4/2016 4:05 PM, Sergey Bylokhov wrote: Hi, Semyon. - It seems that DisplayMode contain the data which were not upscaled to the units instead of pixels. It seems incorrect that it is necessary to convert them here to set the correct size for the

Re: [9] Review Request for 8141528: Test closed/java/awt/FullScreen/DisplayMode/CycleDMImage.java fails for Ubuntu 15.10

2016-10-04 Thread Semyon Sadetsky
On 10/4/2016 4:05 PM, Sergey Bylokhov wrote: Hi, Semyon. - It seems that DisplayMode contain the data which were not upscaled to the units instead of pixels. It seems incorrect that it is necessary to convert them here to set the correct size for the window. Not sure that it is true.

Re: [9] Review Request for 8141528: Test closed/java/awt/FullScreen/DisplayMode/CycleDMImage.java fails for Ubuntu 15.10

2016-10-04 Thread Sergey Bylokhov
Hi, Semyon. - It seems that DisplayMode contain the data which were not upscaled to the units instead of pixels. It seems incorrect that it is necessary to convert them here to set the correct size for the window. - Is it possible to eliminate check for Unity? I guess that if the size of mode

Re: [9] Review Request for 8141528: Test closed/java/awt/FullScreen/DisplayMode/CycleDMImage.java fails for Ubuntu 15.10

2016-10-03 Thread Alexander Zvegintsev
Looks fine. -- Thanks, Alexander. On 10/03/2016 07:38 PM, Semyon Sadetsky wrote: The fix is updated http://cr.openjdk.java.net/~ssadetsky/8141528/webrev.01/ The root case of the issue is that in Unity the screen window size and location are get updated several times after display mode is

Re: [9] Review Request for 8141528: Test closed/java/awt/FullScreen/DisplayMode/CycleDMImage.java fails for Ubuntu 15.10

2016-10-03 Thread Semyon Sadetsky
The fix is updated http://cr.openjdk.java.net/~ssadetsky/8141528/webrev.01/ The root case of the issue is that in Unity the screen window size and location are get updated several times after display mode is changed, and bounds which are set in line 459 of X11GraphicsDevice class are

Re: [9] Review Request for 8141528: Test closed/java/awt/FullScreen/DisplayMode/CycleDMImage.java fails for Ubuntu 15.10

2016-09-08 Thread Alexander Zvegintsev
Hi Semyon, I believe that this webrev should be updated to use isUnityCompiz(). -- Thanks, Alexander. On 07.12.2015 14:11, Semyon Sadetsky wrote: Hello, Please review fix for JDK9: bug: https://bugs.openjdk.java.net/browse/JDK-8141528 webrev:

Re: [9] Review Request for 8141528: Test closed/java/awt/FullScreen/DisplayMode/CycleDMImage.java fails for Ubuntu 15.10

2015-12-13 Thread Semyon Sadetsky
On 12/10/2015 7:37 PM, Semyon Sadetsky wrote: On 12/10/2015 7:02 PM, Sergey Bylokhov wrote: On 10/12/15 18:45, Semyon Sadetsky wrote: On 12/10/2015 5:50 PM, Sergey Bylokhov wrote: On 09/12/15 10:21, Semyon Sadetsky wrote: On 12/8/2015 10:36 PM, Sergey Bylokhov wrote: On 08/12/15

Re: [9] Review Request for 8141528: Test closed/java/awt/FullScreen/DisplayMode/CycleDMImage.java fails for Ubuntu 15.10

2015-12-10 Thread Sergey Bylokhov
On 09/12/15 10:21, Semyon Sadetsky wrote: On 12/8/2015 10:36 PM, Sergey Bylokhov wrote: On 08/12/15 22:07, Semyon Sadetsky wrote: On 12/8/2015 9:11 PM, Sergey Bylokhov wrote: On 08.12.15 21:03, Semyon Sadetsky wrote: The test fails on Ubuntu 14 as well. It only was discovered on Ubunu 15

Re: [9] Review Request for 8141528: Test closed/java/awt/FullScreen/DisplayMode/CycleDMImage.java fails for Ubuntu 15.10

2015-12-10 Thread Semyon Sadetsky
On 12/10/2015 7:02 PM, Sergey Bylokhov wrote: On 10/12/15 18:45, Semyon Sadetsky wrote: On 12/10/2015 5:50 PM, Sergey Bylokhov wrote: On 09/12/15 10:21, Semyon Sadetsky wrote: On 12/8/2015 10:36 PM, Sergey Bylokhov wrote: On 08/12/15 22:07, Semyon Sadetsky wrote: On 12/8/2015 9:11

Re: [9] Review Request for 8141528: Test closed/java/awt/FullScreen/DisplayMode/CycleDMImage.java fails for Ubuntu 15.10

2015-12-08 Thread Sergey Bylokhov
Hi, Semyon. Can you please provide an additional information why compiz in ubuntu 15.10 require this. Is it specified/intended behavior or probably a bug? since it works on ubuntu 14.04. On 07.12.15 14:11, Semyon Sadetsky wrote: Hello, Please review fix for JDK9: bug:

Re: [9] Review Request for 8141528: Test closed/java/awt/FullScreen/DisplayMode/CycleDMImage.java fails for Ubuntu 15.10

2015-12-08 Thread Sergey Bylokhov
On 08.12.15 21:03, Semyon Sadetsky wrote: The test fails on Ubuntu 14 as well. It only was discovered on Ubunu 15 by QA. In the bug description they said that it passes on Ubuntu 14.04. I guess this is the reason why it was filed only now. I think this is because Compiz WM takes more

Re: [9] Review Request for 8141528: Test closed/java/awt/FullScreen/DisplayMode/CycleDMImage.java fails for Ubuntu 15.10

2015-12-08 Thread Semyon Sadetsky
On 12/8/2015 9:11 PM, Sergey Bylokhov wrote: On 08.12.15 21:03, Semyon Sadetsky wrote: The test fails on Ubuntu 14 as well. It only was discovered on Ubunu 15 by QA. In the bug description they said that it passes on Ubuntu 14.04. I guess this is the reason why it was filed only now. On my

Re: [9] Review Request for 8141528: Test closed/java/awt/FullScreen/DisplayMode/CycleDMImage.java fails for Ubuntu 15.10

2015-12-08 Thread Sergey Bylokhov
On 08/12/15 22:07, Semyon Sadetsky wrote: On 12/8/2015 9:11 PM, Sergey Bylokhov wrote: On 08.12.15 21:03, Semyon Sadetsky wrote: The test fails on Ubuntu 14 as well. It only was discovered on Ubunu 15 by QA. In the bug description they said that it passes on Ubuntu 14.04. I guess this is

Re: [9] Review Request for 8141528: Test closed/java/awt/FullScreen/DisplayMode/CycleDMImage.java fails for Ubuntu 15.10

2015-12-08 Thread Semyon Sadetsky
On 12/8/2015 10:36 PM, Sergey Bylokhov wrote: On 08/12/15 22:07, Semyon Sadetsky wrote: On 12/8/2015 9:11 PM, Sergey Bylokhov wrote: On 08.12.15 21:03, Semyon Sadetsky wrote: The test fails on Ubuntu 14 as well. It only was discovered on Ubunu 15 by QA. In the bug description they said

[9] Review Request for 8141528: Test closed/java/awt/FullScreen/DisplayMode/CycleDMImage.java fails for Ubuntu 15.10

2015-12-07 Thread Semyon Sadetsky
Hello, Please review fix for JDK9: bug: https://bugs.openjdk.java.net/browse/JDK-8141528 webrev: http://cr.openjdk.java.net/~ssadetsky/8141528/webrev.00/ Compiz WM requires override redirect for full-screen window to preserve the full size upon display mode switching. --Semyon