Great!,
Thanks for all.
-- Jose Luis
El lun, 03-06-2013 a las 16:30 +0400, Anthony Petrov escribió:
> Hi Jose,
>
> Thank you for the contribution! Your fix is now pushed to the repository:
>
> http://hg.openjdk.java.net/jdk8/awt/jdk/rev/d378104e52e3
>
> --
> best regards,
> Anthony
Hi Jose,
Thank you for the contribution! Your fix is now pushed to the repository:
http://hg.openjdk.java.net/jdk8/awt/jdk/rev/d378104e52e3
--
best regards,
Anthony
On 05/31/13 18:39, Sergey Bylokhov wrote:
Hello, Jose, Anthony.
Fix looks good.
On 31.05.2013 18:33, Anthony Petrov wrote:
A r
Hello, Jose, Anthony.
Fix looks good.
On 31.05.2013 18:33, Anthony Petrov wrote:
A reminder for awt-dev@ folks...
--
best regards,
Anthony
On 05/29/2013 01:57 PM, Anthony Petrov wrote:
Thank you, Jose. Here's an updated webrev:
http://cr.openjdk.java.net/~anthony/8-59-windowClosedEvents-8015
A reminder for awt-dev@ folks...
--
best regards,
Anthony
On 05/29/2013 01:57 PM, Anthony Petrov wrote:
Thank you, Jose. Here's an updated webrev:
http://cr.openjdk.java.net/~anthony/8-59-windowClosedEvents-8015500.1/
The fix still looks fine to me.
Could anyone else review it please?
--
be
Thank you, Jose. Here's an updated webrev:
http://cr.openjdk.java.net/~anthony/8-59-windowClosedEvents-8015500.1/
The fix still looks fine to me.
Could anyone else review it please?
--
best regards,
Anthony
On 05/28/2013 09:03 PM, Jose Luis Martin wrote:
Hi Anthony,
Just fixed. Thanks again
Hi Anthony,
Just fixed. Thanks again.
Best Regards,
-- Jose Luis Martin.
On 28-05-2013 a las 19:13 +0400, Anthony Petrov wrote
> Hi Jose,
>
> I filed a bug for this issue:
> http://bugs.sun.com/view_bug.do?bug_id=8015500
>
> and published your patch as a webrev at:
>
> http://cr.openjdk.j
Hi Jose,
I filed a bug for this issue:
http://bugs.sun.com/view_bug.do?bug_id=8015500
and published your patch as a webrev at:
http://cr.openjdk.java.net/~anthony/8-59-windowClosedEvents-8015500.0/
Please note that in JDK we use 4 spaces (and not TABs characters) for
indenting lines. Could yo
Hi Anthony,
Please, review the patch and test.
Best Regards,
-- Jose Luis Martin.
El mié, 22-05-2013 a las 13:52 +0400, Anthony Petrov escribió:
>
>
> If you and other AWT folks agree with that, could you prepare a patch
> for this change and a jtreg-based regression test (it should be
On 05/21/2013 08:52 PM, Jose Luis Martin wrote:
As I explained below, the doDispose() calls methods that may be
overridden in user applications (e.g. Window.hide()). If you stop
calling this method under certain conditions, you may break those apps
for no good reason.
Yes but, this overriden me
Hi Anthony,
Thanks for replying. I comment inline too.
El mar, 21-05-2013 a las 17:49 +0400, Anthony Petrov escribió:
> Hi,
>
> I'm getting back to this issue. Please see my comments inline:
> On 05/09/2013 02:23 PM, Jose Luis Martin wrote:
> > I update the Test and include two new TestCases:
>
Hi,
I'm getting back to this issue. Please see my comments inline:
On 05/09/2013 02:23 PM, Jose Luis Martin wrote:
I update the Test and include two new TestCases:
- Test if a Window that has been never shown receive the WINDOW_CLOSED
event.
- Test if a child window that never has been shown r
Hi,
I update the Test and include two new TestCases:
- Test if a Window that has been never shown receive the WINDOW_CLOSED
event.
- Test if a child window that never has been shown receive the
WINDOW_CLOSED event on parent dispose().
With the patch applied the second test fails and the doDisp
Hi,
This indeed looks like a bug in AWT. I'm BCC'ing swing-dev@, and CC'ing
awt-dev@ instead (please subscribe to this mailing list before posting
to it).
Here's a question: why do we consider this issue affects child windows
only? If you call dispose() on a regular window several times in a
13 matches
Mail list logo
