Re: Request for review, JDK-8009883, REGRESSION: test/closed/javax/swing/AbstractButton/4246045/bug4246045.java fails

2014-05-23 Thread Petr Pchelko
Hello, Peter. Looks good to me too. With best regards. Petr. On May 23, 2014, at 7:14 PM, Pete Brunet wrote: > Thanks Alexandr. > > So far Alexandr is the only reviewer of this. I'd like one more. > > Thanks, Pete > > On 5/23/14 5:34 AM, Alexander Scherbatiy wrote: >> On 5/22/2014 9:59 PM,

Re: Request for review, JDK-8009883, REGRESSION: test/closed/javax/swing/AbstractButton/4246045/bug4246045.java fails

2014-05-23 Thread Pete Brunet
Thanks Alexandr. So far Alexandr is the only reviewer of this. I'd like one more. Thanks, Pete On 5/23/14 5:34 AM, Alexander Scherbatiy wrote: > On 5/22/2014 9:59 PM, Pete Brunet wrote: >> I'd like one more reviewer of this fix. >> >> Also I removed the @Deprecated and will deal with this in a

Re: Request for review, JDK-8009883, REGRESSION: test/closed/javax/swing/AbstractButton/4246045/bug4246045.java fails

2014-05-23 Thread Alexander Scherbatiy
On 5/22/2014 9:59 PM, Pete Brunet wrote: I'd like one more reviewer of this fix. Also I removed the @Deprecated and will deal with this in a following JBS issue. http://cr.openjdk.java.net/~ptbrunet/JDK-8009883/webrev.04/ The fix looks good for me. Thanks, Alexandr. Pete On 5/21/1

Re: Request for review, JDK-8009883, REGRESSION: test/closed/javax/swing/AbstractButton/4246045/bug4246045.java fails

2014-05-22 Thread Pete Brunet
I'd like one more reviewer of this fix. Also I removed the @Deprecated and will deal with this in a following JBS issue. http://cr.openjdk.java.net/~ptbrunet/JDK-8009883/webrev.04/ Pete On 5/21/14 10:08 AM, Pete Brunet wrote: > On 5/21/14 7:04 AM, Alexander Scherbatiy wrote: >> On 5/21/2014 2:5

Re: Request for review, JDK-8009883, REGRESSION: test/closed/javax/swing/AbstractButton/4246045/bug4246045.java fails

2014-05-21 Thread Pete Brunet
On 5/21/14 7:04 AM, Alexander Scherbatiy wrote: > On 5/21/2014 2:56 PM, Alexander Scherbatiy wrote: >> On 5/20/2014 1:10 AM, Pete Brunet wrote: >>> On 5/16/14 11:04 AM, Pete Brunet wrote: On 5/16/14 10:45 AM, Alexander Scherbatiy wrote: > On 5/16/2014 7:15 PM, Pete Brunet wrote: >> On

Re: Request for review, JDK-8009883, REGRESSION: test/closed/javax/swing/AbstractButton/4246045/bug4246045.java fails

2014-05-21 Thread Alexander Scherbatiy
On 5/21/2014 2:56 PM, Alexander Scherbatiy wrote: On 5/20/2014 1:10 AM, Pete Brunet wrote: On 5/16/14 11:04 AM, Pete Brunet wrote: On 5/16/14 10:45 AM, Alexander Scherbatiy wrote: On 5/16/2014 7:15 PM, Pete Brunet wrote: On 5/16/14 6:45 AM, Alexander Scherbatiy wrote: Hi Peter, Is t

Re: Request for review, JDK-8009883, REGRESSION: test/closed/javax/swing/AbstractButton/4246045/bug4246045.java fails

2014-05-21 Thread Alexander Scherbatiy
On 5/20/2014 1:10 AM, Pete Brunet wrote: On 5/16/14 11:04 AM, Pete Brunet wrote: On 5/16/14 10:45 AM, Alexander Scherbatiy wrote: On 5/16/2014 7:15 PM, Pete Brunet wrote: On 5/16/14 6:45 AM, Alexander Scherbatiy wrote: Hi Peter, Is there any difference between AccessibleAWTFocusHandl

Re: Request for review, JDK-8009883, REGRESSION: test/closed/javax/swing/AbstractButton/4246045/bug4246045.java fails

2014-05-19 Thread Pete Brunet
On 5/16/14 11:04 AM, Pete Brunet wrote: > On 5/16/14 10:45 AM, Alexander Scherbatiy wrote: >> On 5/16/2014 7:15 PM, Pete Brunet wrote: >>> On 5/16/14 6:45 AM, Alexander Scherbatiy wrote: Hi Peter, Is there any difference between AccessibleAWTFocusHandler and AccessibleFoc

Re: Request for review, JDK-8009883, REGRESSION: test/closed/javax/swing/AbstractButton/4246045/bug4246045.java fails

2014-05-16 Thread Pete Brunet
On 5/16/14 10:45 AM, Alexander Scherbatiy wrote: > On 5/16/2014 7:15 PM, Pete Brunet wrote: >> On 5/16/14 6:45 AM, Alexander Scherbatiy wrote: >>>Hi Peter, >>> >>>Is there any difference between AccessibleAWTFocusHandler and >>> AccessibleFocusHandler classes? >> Hi Alexandr, The former is

Re: Request for review, JDK-8009883, REGRESSION: test/closed/javax/swing/AbstractButton/4246045/bug4246045.java fails

2014-05-16 Thread Alexander Scherbatiy
On 5/16/2014 7:15 PM, Pete Brunet wrote: On 5/16/14 6:45 AM, Alexander Scherbatiy wrote: Hi Peter, Is there any difference between AccessibleAWTFocusHandler and AccessibleFocusHandler classes? Hi Alexandr, The former is the focus handler used by the inner class accessibility support for

Re: Request for review, JDK-8009883, REGRESSION: test/closed/javax/swing/AbstractButton/4246045/bug4246045.java fails

2014-05-16 Thread Pete Brunet
On 5/16/14 6:45 AM, Alexander Scherbatiy wrote: > > Hi Peter, > > Is there any difference between AccessibleAWTFocusHandler and > AccessibleFocusHandler classes? Hi Alexandr, The former is the focus handler used by the inner class accessibility support for an AWT Component and the latter is th

Re: Request for review, JDK-8009883, REGRESSION: test/closed/javax/swing/AbstractButton/4246045/bug4246045.java fails

2014-05-16 Thread Alexander Scherbatiy
Hi Peter, Is there any difference between AccessibleAWTFocusHandler and AccessibleFocusHandler classes? Thanks, Alexandr. On 5/7/2014 5:45 AM, Pete Brunet wrote: Hi Swing and AWT teams, (and Artem since you were involved in the 7179482 fix), I'd appreciate your review for a fix to

Request for review, JDK-8009883, REGRESSION: test/closed/javax/swing/AbstractButton/4246045/bug4246045.java fails

2014-05-06 Thread Pete Brunet
Hi Swing and AWT teams, (and Artem since you were involved in the 7179482 fix), I'd appreciate your review for a fix to a regression in java.awt.Component and javax.swing.JComponent. Original bug: https://bugs.openjdk.java.net/browse/JDK-7179482 Orignal CCC: 7179482 Regression Bug: https://bugs.o