Re: Please review changes in regression test /java/awt/TestArea/UsingWithMouse.java (second version of patch)

2010-01-26 Thread Pavel Tisnovsky
Artem Ananiev wrote: On 1/26/2010 2:57 PM, Pavel Tisnovsky wrote: Artem Ananiev wrote: I've added synchronization of scrolling using method SunToolkit.realSync(), it seems to works perfectly on RHEL x86_64 + Gnome and Fedora 10 i386 + Gnome. Thanks Anthony Petrov for his tip! the problem loo

Re: Please review changes in regression test /java/awt/TestArea/UsingWithMouse.java (second version of patch)

2010-01-26 Thread Artem Ananiev
On 1/26/2010 2:57 PM, Pavel Tisnovsky wrote: Artem Ananiev wrote: I've added synchronization of scrolling using method SunToolkit.realSync(), it seems to works perfectly on RHEL x86_64 + Gnome and Fedora 10 i386 + Gnome. Thanks Anthony Petrov for his tip! the problem looks really, really stra

Re: Please review changes in regression test /java/awt/TestArea/UsingWithMouse.java (second version of patch)

2010-01-26 Thread Pavel Tisnovsky
Artem Ananiev wrote: I've added synchronization of scrolling using method SunToolkit.realSync(), it seems to works perfectly on RHEL x86_64 + Gnome and Fedora 10 i386 + Gnome. Thanks Anthony Petrov for his tip! the problem looks really, really strange... Util.waitForIdle() is implemented exact

Re: Please review changes in regression test /java/awt/TestArea/UsingWithMouse.java (second version of patch)

2010-01-26 Thread Artem Ananiev
Hi, Pavel, On 1/26/2010 11:31 AM, Pavel Tisnovsky wrote: Hi, please review changes made in regression test /java/awt/TestArea/UsingWithMouse.java. Webrev is available at http://cr.openjdk.java.net/~ptisnovs/SelectionAutoscrollTest2/ I've added synchronization of scrolling using method SunTool

Re: Please review changes in regression test /java/awt/TestArea/UsingWithMouse.java (second version of patch) - approved

2010-01-26 Thread Anthony Petrov
Pavel, The fix looks great. AWT team approves the changes. Please feel free to push the changeset to both jdk6 and jdk7 (awt-gate). Thank you for the fix! -- best regards, Anthony On 1/26/2010 11:31 AM Pavel Tisnovsky wrote: Hi, please review changes made in regression test /java/awt/TestAr

Please review changes in regression test /java/awt/TestArea/UsingWithMouse.java (second version of patch)

2010-01-26 Thread Pavel Tisnovsky
Hi, please review changes made in regression test /java/awt/TestArea/UsingWithMouse.java. Webrev is available at http://cr.openjdk.java.net/~ptisnovs/SelectionAutoscrollTest2/ I've added synchronization of scrolling using method SunToolkit.realSync(), it seems to works perfectly on RHEL x8

Re: Please review changes in regression test /java/awt/TestArea/UsingWithMouse.java

2010-01-26 Thread Joseph D. Darcy
Pavel Tisnovsky wrote: Hi Anthony, thank you for the tip, I'll try to use realSync(), it seems to be the best solution. If the fix is approved by the awt team, I'm happy for the test change to go back into OpenJDK 6. -Joe

Re: Please review changes in regression test /java/awt/TestArea/UsingWithMouse.java

2010-01-25 Thread Pavel Tisnovsky
t: Re: Please review changes in regression test /java/awt/TestArea/UsingWithMouse.java Hi Pavel, I think what you really need to use here instead of Thread.sleep() is the ((sun.awt.SunToolkit)Toolkit.getDefaultToolkit()).realSync(); method which actually ends up in calling the XSync(), and therefore

Re: Please review changes in regression test /java/awt/TestArea/UsingWithMouse.java

2010-01-25 Thread Anthony Petrov
Hi Pavel, I think what you really need to use here instead of Thread.sleep() is the ((sun.awt.SunToolkit)Toolkit.getDefaultToolkit()).realSync(); method which actually ends up in calling the XSync(), and therefore makes sure the X server processes the requests we're sending. waitForIdle() can

Please review changes in regression test /java/awt/TestArea/UsingWithMouse.java

2010-01-25 Thread Pavel Tisnovsky
Hi, please review changes made in regression test /java/awt/TestArea/UsingWithMouse.java. Webrev is available at http://cr.openjdk.java.net/~ptisnovs/SelectionAutoscrollTest/ There's added small delay between each scroll event, so the scrolling (and related text selection by mouse cursor)