Re: RFR(S) : 8240904 : Screen flashes on test failures when running tests from make

On 2020-04-16 19:02, Igor Ignatyev wrote: Hi Erik, sure, I've actually replaced one long statement w/ multiple shorter ones, which made the comment section redundant -- http://cr.openjdk.java.net/~iignatyev//8240904/webrev.01 Looks g

Re: RFR(S) : 8240904 : Screen flashes on test failures when running tests from make

Thanks, that looks much better to me. /Erik On 2020-04-16 10:02, Igor Ignatyev wrote: Hi Erik, sure, I've actually replaced one long statement w/ multiple shorter ones, which made the comment section redundant -- http://cr.openjdk.java.net/~iignatyev//8240904/webrev.01 Thanks, -- Igor On

Re: RFR(S) : 8240904 : Screen flashes on test failures when running tests from make

Hi Erik, sure, I've actually replaced one long statement w/ multiple shorter ones, which made the comment section redundant -- http://cr.openjdk.java.net/~iignatyev//8240904/webrev.01 Thanks, -- Igor > On Apr 16, 2020, at 6:17 AM, Eri

Re: RFR(S) : 8240904 : Screen flashes on test failures when running tests from make

Thanks for your review, Sergey. -- Igor > On Apr 16, 2020, at 1:43 AM, Sergey Bylokhov > wrote: > > Looks fine. > > On 4/15/20 10:22 pm, Igor Ignatyev wrote: >> http://cr.openjdk.java.net/~iignatyev//8240904/webrev.00 >>> 35 lines changed: 26 ins; 0 del; 10 mod >> Hi all, >> 8233827[1] which

Re: RFR(S) : 8240904 : Screen flashes on test failures when running tests from make

Looks ok to me. Would it be possible to break up the long lines a bit to improve readability? Backslash escape for newlines should work in properties files. /Erik On 2020-04-15 22:22, Igor Ignatyev wrote: http://cr.openjdk.java.net/~iignatyev//8240904/webrev.00 35 lines changed: 26 ins; 0 de

Re: RFR(S) : 8240904 : Screen flashes on test failures when running tests from make

Looks fine. On 4/15/20 10:22 pm, Igor Ignatyev wrote: http://cr.openjdk.java.net/~iignatyev//8240904/webrev.00 35 lines changed: 26 ins; 0 del; 10 mod Hi all, 8233827[1] which added screenshots to so-called failure handler had an unexpected side-effect on linux, where users might observer

RFR(S) : 8240904 : Screen flashes on test failures when running tests from make

http://cr.openjdk.java.net/~iignatyev//8240904/webrev.00 > 35 lines changed: 26 ins; 0 del; 10 mod Hi all, 8233827[1] which added screenshots to so-called failure handler had an unexpected side-effect on linux, where users might observer flashes each time a screenshot is taken, which, to put i