Re: RFR(XS): 8201524: [AIX] Don't link libfontmanager against libawt_headless

On 04/13/2018 12:44 PM, Volker Simonis wrote: Phil Race > schrieb am Fr. 13. Apr. 2018 um 19:21: I suppose this potentially helps the concurrency of the build ? I can't think of why this would be a problem now there is no

Re: RFR(XS): 8201524: [AIX] Don't link libfontmanager against libawt_headless

On 2018-04-13 12:44, Volker Simonis wrote: Phil Race > schrieb am Fr. 13. Apr. 2018 um 19:21: I suppose this potentially helps the concurrency of the build ? I can't think of why this would be a problem now there is no

Re: RFR(XS): 8201524: [AIX] Don't link libfontmanager against libawt_headless

Phil Race schrieb am Fr. 13. Apr. 2018 um 19:21: > > I suppose this potentially helps the concurrency of the build ? > I can't think of why this would be a problem now there is no > compile-time linking > involved and it seems Linux was already fine without this, > but a

Re: RFR(XS): 8201524: [AIX] Don't link libfontmanager against libawt_headless

Yes, we don't want unneeded dependencies declared as it both potentially slows down the build (though this removal will not have any measurable impact) as well as confuses humans trying to make sense of the makefiles. This removal should be fine as we don't link to libawt_xawt on any platform

Re: RFR(XS): 8201524: [AIX] Don't link libfontmanager against libawt_headless

Looks good, thanks! /Erik On 2018-04-13 09:22, Volker Simonis wrote: Hi Erik, thanks for looking at the patch and good catch! You're right that the dependency can now be removed. Here's the new webrev: http://cr.openjdk.java.net/~simonis/webrevs/2018/8201524.v1 Regards, Volker On Fri, Apr

Re: RFR(XS): 8201524: [AIX] Don't link libfontmanager against libawt_headless

I suppose this potentially helps the concurrency of the build ? I can't think of why this would be a problem now there is no compile-time linking involved and it seems Linux was already fine without this, but a jdk-submit would be prudent .. -phil. On 04/13/2018 09:22 AM, Volker Simonis

Re: RFR(XS): 8201524: [AIX] Don't link libfontmanager against libawt_headless

Hi Erik, thanks for looking at the patch and good catch! You're right that the dependency can now be removed. Here's the new webrev: http://cr.openjdk.java.net/~simonis/webrevs/2018/8201524.v1 Regards, Volker On Fri, Apr 13, 2018 at 6:00 PM, Erik Joelsson wrote: >

Re: RFR(XS): 8201524: [AIX] Don't link libfontmanager against libawt_headless

Hello Volker, The change looks good, but now that we no longer link against libawt_headless, we should also remove the make dependency a few lines down. (Should have been done already for Solaris.) /Erik On 2018-04-13 06:28, Volker Simonis wrote: Hi, can I please have a review for this

Re: RFR(XS): 8201524: [AIX] Don't link libfontmanager against libawt_headless

t> > Subject: RFR(XS): 8201524: [AIX] Don't link libfontmanager > against libawt_headless > > Hi, > > can I please have a review for this tiny AIX cleanup: > > http://cr.openjdk.java.net/~simonis/webrevs/2018/8201524/ > https://bugs.openjdk.java.net/browse/JDK-820

RFR(XS): 8201524: [AIX] Don't link libfontmanager against libawt_headless

Hi, can I please have a review for this tiny AIX cleanup: http://cr.openjdk.java.net/~simonis/webrevs/2018/8201524/ https://bugs.openjdk.java.net/browse/JDK-8201524 This is a follow up change of JDK-8196516 which discovered that on AIX libfontmanager is always linked against libawt_headless at