Re: RFR: 8155772: gtk3_interface.c compilation error on Ubuntu 12.10

2016-04-29 Thread Sergey Bylokhov
+1 On 30.04.16 0:27, Kevin Rushforth wrote: I am not a "R" reviewer for AWT, but using NULL as if it were an int is incorrect, so this fix looks good to me. -- Kevin Phil Race wrote: Bug : https://bugs.openjdk.java.net/browse/JDK-8155772 On my system in this file it appears NULL is "#define

Re: RFR: 8155772: gtk3_interface.c compilation error on Ubuntu 12.10

2016-04-29 Thread Kevin Rushforth
I am not a "R" reviewer for AWT, but using NULL as if it were an int is incorrect, so this fix looks good to me. -- Kevin Phil Race wrote: Bug : https://bugs.openjdk.java.net/browse/JDK-8155772 On my system in this file it appears NULL is "#define (void*)0 which causes the error "error: i

RFR: 8155772: gtk3_interface.c compilation error on Ubuntu 12.10

2016-04-29 Thread Phil Race
Bug : https://bugs.openjdk.java.net/browse/JDK-8155772 On my system in this file it appears NULL is "#define (void*)0 which causes the error "error: initialization makes integer from pointer without a cast [-Werror]" Webrev to fix in-line below. -phil. diff --git a/src/java.desktop/unix/na