Re: RFR: 8198649 : Switch AWT/Swing's default GTK version to 3

2018-03-17 Thread Prasanta Sadhukhan
+1 Regards Prasanta On 3/16/2018 11:04 PM, Phil Race wrote: Bug: https://bugs.openjdk.java.net/browse/JDK-8198649 Webrev: http://cr.openjdk.java.net/~prr/8198649/ This is a very small change to switch the default GTK library loaded from GTK 2.2 to GTK 3. Both are supported as of JDK 9 but it s

Re: RFR: 8198649 : Switch AWT/Swing's default GTK version to 3

2018-03-16 Thread Kevin Rushforth
This looks fine to me. I checked FX / Swing interop and it works as expected. If there is a mismatch in defaults (which there will be until FX switches the default, or after we which when running FX on an older JDK), then whichever toolkit loads first will use its default, and then the other on

Re: RFR: 8198649 : Switch AWT/Swing's default GTK version to 3

2018-03-16 Thread Krishna Addepalli
Hi Phil, The change looks fine for me. Thanks, Krishna -Original Message- From: Phil Race Sent: Friday, March 16, 2018 11:05 PM To: awt-dev@openjdk.java.net; swing-...@openjdk.java.net Subject: RFR: 8198649 : Switch AWT/Swing's default GTK version to 3 Bug:

RFR: 8198649 : Switch AWT/Swing's default GTK version to 3

2018-03-16 Thread Phil Race
Bug: https://bugs.openjdk.java.net/browse/JDK-8198649 Webrev: http://cr.openjdk.java.net/~prr/8198649/ This is a very small change to switch the default GTK library loaded from GTK 2.2 to GTK 3. Both are supported as of JDK 9 but it still defaults to 2.2 and you use jdk.gtk.version=3 to switch.