That looks better.
-phil.
On 12/12/18 12:59 AM, Ichiroh Takiguchi wrote:
Hello.
I'm very sorry.
I forgot to put @test tag into FontChangeTest.java testcase.
(Thanks, Phil)
Could you review the fix again ?
Bug: https://bugs.openjdk.java.net/browse/JDK-8211267
Change: https://cr.openjdk.jav
Hello.
I'm very sorry.
I forgot to put @test tag into FontChangeTest.java testcase.
(Thanks, Phil)
Could you review the fix again ?
Bug:https://bugs.openjdk.java.net/browse/JDK-8211267
Change: https://cr.openjdk.java.net/~itakiguchi/8211267/webrev.03/
Thanks,
Ichiroh Takiguchi
On 2018-12-
Looks fine.
On 03/12/2018 00:22, Ichiroh Takiguchi wrote:
Hello.
Thanks, Sergey.
I created new test case for JDK-8214298.
I merged JDK-8211267 & JDK-8214298.
I removed interactive test case and added JDK-8214298's code.
Could you review the fix ?
Bug: https://bugs.openjdk.java.net/browse/
Hello.
Thanks, Sergey.
I created new test case for JDK-8214298.
I merged JDK-8211267 & JDK-8214298.
I removed interactive test case and added JDK-8214298's code.
Could you review the fix ?
Bug:https://bugs.openjdk.java.net/browse/JDK-8211267
Change: https://cr.openjdk.java.net/~itakiguchi/
If it requires some user interaction to cause it, because it needs to be
triggered
in a narrow way then see the many AWT tests that use Robot ..
If it just needs a setFont call on the EDT perhaps you can do that
programmatically.
I hope you can call getFont() to verify success rather than having
Thanks Phil, and I appreciate your suggestion.
For all,
Is there some non-interactive examples?
Next step,
I'll migrate this testcase to non-interactive version.
Thanks,
On 2018-10-31 02:46, Phil Race wrote:
Looks good. A bit disappointing the test has to be manual .. they
rarely get run.
-p
Looks good. A bit disappointing the test has to be manual .. they rarely
get run.
-phil.
On 10/30/2018 10:39 AM, Ichiroh Takiguchi wrote:
Hello.
Additional reviewer is required.
Please let me know if you have question and suggestion.
Thanks,
Ichiroh Takiguchi
IBM Japan, Ltd.
On 2018-10-05 0
Hello.
Additional reviewer is required.
Please let me know if you have question and suggestion.
Thanks,
Ichiroh Takiguchi
IBM Japan, Ltd.
On 2018-10-05 06:21, Sergey Bylokhov wrote:
Looks fine.
On 02/10/2018 03:44, Ichiroh Takiguchi wrote:
Hello Sergey.
I appreciate your suggestion.
Yeah, I
Looks fine.
On 02/10/2018 03:44, Ichiroh Takiguchi wrote:
Hello Sergey.
I appreciate your suggestion.
Yeah, I should care about StateLock...
So if xtext.setFont(font) is not called,
also xtext.validate() is not called.
Could you review fix and testcase again ?
Bug: https://bugs.openjdk.ja
Hello Sergey.
I appreciate your suggestion.
Yeah, I should care about StateLock...
So if xtext.setFont(font) is not called,
also xtext.validate() is not called.
Could you review fix and testcase again ?
Bug: https://bugs.openjdk.java.net/browse/JDK-8211267
Change: https://cr.openjdk.java.ne
Hi, Ichiroh.
I guess you need to remove the old call xtext.validate() and the new
validate should be called after xtext.setFont(font);
But I am not sure that this call is necessary, possibly setFont() itself
will call validate? It is also necessary to check that the call to
validate(which use T
Hello.
Could you review fix and testcase ?
Bug:https://bugs.openjdk.java.net/browse/JDK-8211267
Change: https://cr.openjdk.java.net/~itakiguchi/8211267/webrev.00/
I'd like to obtain a sponsor for this issue.
Thanks,
Ichiroh Takiguchi
IBM Japan, Ltd.
On 2018-09-05 23:08, Ichiroh Takiguchi w
12 matches
Mail list logo
