Re: RFR: 8240487 : Cleanup whitespace in .cc, .hh, .m, and .mm files

2020-10-13 Thread Chris Plummer
Hi Philip, The MacosxDebuggerLocal.m changes look fine. It took a while to detect what was actually changed since the html files seem to convert tabs to spaces. I ended up looking in the patch file, and could see the tabs there. thanks, Chris On 8/5/20 6:46 PM, Philip Race wrote: Bug: http

Re: [OpenJDK 2D-Dev] RFR: 8240487 : Cleanup whitespace in .cc, .hh, .m, and .mm files

2020-08-06 Thread Sergey Bylokhov
Hi, Phil. Maybe we can enable jcheck for such files at the same time? On 05.08.2020 18:46, Philip Race wrote: Bug: https://bugs.openjdk.java.net/browse/JDK-8240487 Webrev: http://cr.openjdk.java.net/~prr/8240487/ In advance of the move to Project Skara/git it is desirable to clean up whitespa

Re: [OpenJDK 2D-Dev] RFR: 8240487 : Cleanup whitespace in .cc, .hh, .m, and .mm files

2020-08-06 Thread Kevin Rushforth
Looks good to me. I verified that the only changes are whitespace changes, and that after applying the patch there are no more whitespace errors. +1 -- Kevin On 8/5/2020 6:46 PM, Philip Race wrote: Bug: https://bugs.openjdk.java.net/browse/JDK-8240487 Webrev: http://cr.openjdk.java.net/~prr

Re: RFR: 8240487 : Cleanup whitespace in .cc, .hh, .m, and .mm files

2020-08-05 Thread Alexander Zuev
Looks fine to me. Had to recall the vi settings that visualize spaces and tabs but it was worth it. Some places looks hilarious, like this one: http://cr.openjdk.java.net/~kizune/tmp/extra_spaces.png I mean - someone spent a lot of time creating this invisible art. Good it is going to be gone. /

RFR: 8240487 : Cleanup whitespace in .cc, .hh, .m, and .mm files

2020-08-05 Thread Philip Race
Bug: https://bugs.openjdk.java.net/browse/JDK-8240487 Webrev: http://cr.openjdk.java.net/~prr/8240487/ In advance of the move to Project Skara/git it is desirable to clean up whitespace in source files that are not currently checked by jcheck so we can add these extensions to jcheck at that tim