Re: RFR: 8253681: closed java/awt/dnd/MouseEventAfterStartDragTest/MouseEventAfterStartDragTest.html test failed

2020-10-08 Thread Aleksey Shipilev
On Wed, 7 Oct 2020 23:35:00 GMT, Sergey Bylokhov wrote: >> As far as I can see, the only effect `volatile` has here is making sure the >> successive calls to `checkEvent` eventually >> get the updated value of `discardingMouseEvents`. This does not seem to >> resolve the original race: calls to

Re: RFR: 8253681: closed java/awt/dnd/MouseEventAfterStartDragTest/MouseEventAfterStartDragTest.html test failed

2020-10-07 Thread Sergey Bylokhov
On Wed, 7 Oct 2020 07:13:53 GMT, Aleksey Shipilev wrote: > The iron-clad fix would be to synchronously insert something like > `DiscardMouseEvent` on the beginning of event queue, > and `AcceptMouseEvent` at the end of it, and let the `EventQueue` processor > thread manage the flag -- so that >

Re: RFR: 8253681: closed java/awt/dnd/MouseEventAfterStartDragTest/MouseEventAfterStartDragTest.html test failed

2020-10-07 Thread Aleksey Shipilev
On Sat, 3 Oct 2020 00:03:07 GMT, Sergey Bylokhov wrote: > The "discardingMouseEvents" flag in the SunDragSourceContextPeer class is > used on the different threads without any > synchronization. As far as I can see, the only effect `volatile` has here is making sure the successive calls to `ch

RFR: 8253681: closed java/awt/dnd/MouseEventAfterStartDragTest/MouseEventAfterStartDragTest.html test failed

2020-10-02 Thread Sergey Bylokhov
The "discardingMouseEvents" flag in the SunDragSourceContextPeer class is used on the different threads without any synchronization. - Commit messages: - Update SunDragSourceContextPeer.java Changes: https://git.openjdk.java.net/jdk/pull/491/files Webrev: https://webrevs.openjdk.j