Re: RFR: 8258805: Japanese characters not entered by mouse click on Windows 10 [v2]

2021-01-22 Thread Ichiroh Takiguchi
On Thu, 21 Jan 2021 21:41:09 GMT, Dmitry Markov wrote: >> Marked as reviewed by aivanov (Reviewer). > >> Hi, >> >> AWT's `TextComponent` is a `peered` input client, and Swing's >> `JTextComponent` is an `active` input client. Thus it is OK to behave >> differently. I would expect that AWT's on

Re: RFR: 8258805: Japanese characters not entered by mouse click on Windows 10 [v2]

2021-01-21 Thread Dmitry Markov
On Thu, 21 Jan 2021 21:34:25 GMT, Alexey Ivanov wrote: >> Dmitry Markov has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Use endComposition() instead of endCompositionNative() > > Marked as reviewed by aivanov (Reviewer). > Hi, > > AWT'

Re: RFR: 8258805: Japanese characters not entered by mouse click on Windows 10

2021-01-21 Thread Naoto Sato
On Thu, 21 Jan 2021 21:17:53 GMT, Dmitry Markov wrote: >>> > > Now we will commit the composition string if there is an active client. >>> > > That changes eliminates the issue described in JDK-8258805. Also the >>> > > behaviour of AWTTextTest1 is the same as it used to be on the previous >>>

Re: RFR: 8258805: Japanese characters not entered by mouse click on Windows 10 [v2]

2021-01-21 Thread Alexey Ivanov
On Thu, 21 Jan 2021 13:51:58 GMT, Dmitry Markov wrote: >> Problem description: >> The IME behaviour has changed starting from recent Windows 10 builds. In >> particular if the complex characters (Japanese, Chinese, etc.) are entered >> to some component and the focus is transferred to another c

Re: RFR: 8258805: Japanese characters not entered by mouse click on Windows 10

2021-01-21 Thread Dmitry Markov
On Thu, 21 Jan 2021 19:25:16 GMT, Alexey Ivanov wrote: > I admit I am even more confused now. To me, the description in the comment > above is nearly the same as in [JBS > comment](https://bugs.openjdk.java.net/browse/JDK-8258805?focusedCommentId=14391025&page=com.atlassian.jira.plugin.system.i

Re: RFR: 8258805: Japanese characters not entered by mouse click on Windows 10

2021-01-21 Thread Alexey Ivanov
On Thu, 21 Jan 2021 14:54:34 GMT, Dmitry Markov wrote: >>> Now we will commit the composition string if there is an active client. >>> That changes eliminates the issue described in JDK-8258805. Also the >>> behaviour of AWTTextTest1 is the same as it used to be on the previous >>> versions w/

Re: RFR: 8258805: Japanese characters not entered by mouse click on Windows 10

2021-01-21 Thread Dmitry Markov
On Thu, 21 Jan 2021 14:18:43 GMT, Alexey Ivanov wrote: > > Now we will commit the composition string if there is an active client. > > That changes eliminates the issue described in JDK-8258805. Also the > > behaviour of AWTTextTest1 is the same as it used to be on the previous > > versions w/

Re: RFR: 8258805: Japanese characters not entered by mouse click on Windows 10

2021-01-21 Thread Alexey Ivanov
On Thu, 21 Jan 2021 13:47:30 GMT, Dmitry Markov wrote: > Now we will commit the composition string if there is an active client. That > changes eliminates the issue described in JDK-8258805. Also the behaviour of > AWTTextTest1 is the same as it used to be on the previous versions w/o the > fi

Re: RFR: 8258805: Japanese characters not entered by mouse click on Windows 10

2021-01-21 Thread Dmitry Markov
On Wed, 20 Jan 2021 12:28:36 GMT, Alexey Ivanov wrote: >>> > Fix: >>> > It is necessary to take care of unconfirmed composition string once the >>> > IME is going to be disabled. >>> >>> The fix commits the unconfirmed composition string. Committing is better >>> than discarding. Is it possibl

Re: RFR: 8258805: Japanese characters not entered by mouse click on Windows 10 [v2]

2021-01-21 Thread Dmitry Markov
> Problem description: > The IME behaviour has changed starting from recent Windows 10 builds. In > particular if the complex characters (Japanese, Chinese, etc.) are entered to > some component and the focus is transferred to another component (which does > not support the IM) the IM is disable

Re: RFR: 8258805: Japanese characters not entered by mouse click on Windows 10

2021-01-20 Thread Alexey Ivanov
On Tue, 19 Jan 2021 13:18:22 GMT, Dmitry Markov wrote: > > The fix commits the unconfirmed composition string. Committing is better > > than discarding. Is it possible to preserve the > > state and to leave the string uncommitted? > > The fix reverts the previous (correct) behaviour back. Acco

Re: RFR: 8258805: Japanese characters not entered by mouse click on Windows 10

2021-01-20 Thread Dmitry Markov
On Wed, 20 Jan 2021 07:35:18 GMT, Ichiroh Takiguchi wrote: >> How do the native components work in that case like awt textarea or external >> apps like notepad? > >> How do the native components work in that case like awt textarea or external >> apps like notepad? > > I tested TextField+TextF

Re: RFR: 8258805: Japanese characters not entered by mouse click on Windows 10

2021-01-19 Thread Ichiroh Takiguchi
On Wed, 20 Jan 2021 05:43:51 GMT, Sergey Bylokhov wrote: > How do the native components work in that case like awt textarea or external > apps like notepad? I tested TextField+TextField, TextArea+TextArea, TextArea+TextField. Without fix: Preedit string was cancel by input focus change. With fi

Re: RFR: 8258805: Japanese characters not entered by mouse click on Windows 10

2021-01-19 Thread Sergey Bylokhov
On Wed, 20 Jan 2021 05:19:15 GMT, Ichiroh Takiguchi wrote: >> Hello Dmitry. >> Sorry, I should use GitHub instead of mailing list. >> I tested your fix, I saw side effect by committing preedit string. >> I'll give you detail information. > > I tried attached testcase. > import java.awt.*; > impo

Re: RFR: 8258805: Japanese characters not entered by mouse click on Windows 10

2021-01-19 Thread Ichiroh Takiguchi
On Tue, 19 Jan 2021 16:31:58 GMT, Ichiroh Takiguchi wrote: >>> > Fix: >>> > It is necessary to take care of unconfirmed composition string once the >>> > IME is going to be disabled. >>> >>> The fix commits the unconfirmed composition string. Committing is better >>> than discarding. Is it po

Re: RFR: 8258805: Japanese characters not entered by mouse click on Windows 10

2021-01-19 Thread Ichiroh Takiguchi
On Tue, 19 Jan 2021 13:18:22 GMT, Dmitry Markov wrote: >>> Fix: >>> It is necessary to take care of unconfirmed composition string once the IME >>> is going to be disabled. >> >> The fix commits the unconfirmed composition string. Committing is better >> than discarding. Is it possible to pres

Re: RFR: 8258805: Japanese characters not entered by mouse click on Windows 10

2021-01-19 Thread Dmitry Markov
On Tue, 19 Jan 2021 12:44:22 GMT, Alexey Ivanov wrote: > > Fix: > > It is necessary to take care of unconfirmed composition string once the IME > > is going to be disabled. > > The fix commits the unconfirmed composition string. Committing is better than > discarding. Is it possible to preserv

Re: RFR: 8258805: Japanese characters not entered by mouse click on Windows 10

2021-01-19 Thread Alexey Ivanov
On Tue, 19 Jan 2021 11:10:35 GMT, Dmitry Markov wrote: > Fix: > It is necessary to take care of unconfirmed composition string once the IME > is going to be disabled. The fix commits the unconfirmed composition string. Committing is better than discarding. Is it possible to preserve the state

Re: [EXTERNAL] RFR: 8258805: Japanese characters not entered by mouse click on Windows 10

2021-01-19 Thread Dmitry Markov
Hi Ichiron, I have updated the bug. Now the test, steps to reproduce and other details are available. Please let me know if you need anything else. Regards, Dmitry > On 19 Jan 2021, at 11:44, Ichiroh Takiguchi > wrote: > > Hello Dmitry. > > The bugid seems to be private, so I don't know the

Re: [EXTERNAL] RFR: 8258805: Japanese characters not entered by mouse click on Windows 10

2021-01-19 Thread Ichiroh Takiguchi
Hello Dmitry. The bugid seems to be private, so I don't know the details. I think the current code can change the candidate string after getting the focus. If possible, could you show me the test instructions ? Thanks, Ichiroh Takiguchi On 2021-01-19 20:16, Dmitry Markov wrote: Problem descr

RFR: 8258805: Japanese characters not entered by mouse click on Windows 10

2021-01-19 Thread Dmitry Markov
Problem description: The IME behaviour has changed starting from recent Windows 10 builds. In particular if the complex characters (Japanese, Chinese, etc.) are entered to some component and the focus is transferred to another component (which does not support the IM) the IM is disabled and the