Re: RFR: 8263846: Bad JNI lookup getFocusOwner in accessibility code on Mac OS X [v3]

2021-03-20 Thread Phil Race
On Sat, 20 Mar 2021 17:19:50 GMT, Alexander Zuev wrote: >> 8263846: Bad JNI lookup getFocusOwner in accessibility code on Mac OS X > > Alexander Zuev has updated the pull request incrementally with one additional > commit since the last revision: > > Reverting the change for

Re: RFR: 8263846: Bad JNI lookup getFocusOwner in accessibility code on Mac OS X [v2]

2021-03-20 Thread Alexander Zuev
On Sat, 20 Mar 2021 17:06:38 GMT, Phil Race wrote: >> Alexander Zuev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Fixing accessibilityIndexOfChild in the same way > >

Re: RFR: 8263846: Bad JNI lookup getFocusOwner in accessibility code on Mac OS X [v3]

2021-03-20 Thread Alexander Zuev
On Sat, 20 Mar 2021 17:07:41 GMT, Phil Race wrote: >> It made it visible however it is just a good practice not to assume that >> class reference is already initialized before using it. So, yes, while i was >> not seeing any failures in accessibilityIndexOfChild i might fix it as well. > > If

Re: RFR: 8263846: Bad JNI lookup getFocusOwner in accessibility code on Mac OS X [v3]

2021-03-20 Thread Alexander Zuev
> 8263846: Bad JNI lookup getFocusOwner in accessibility code on Mac OS X Alexander Zuev has updated the pull request incrementally with one additional commit since the last revision: Reverting the change for accessibilityIndexOfChild since macro used there takes care of the class

Re: RFR: 8263846: Bad JNI lookup getFocusOwner in accessibility code on Mac OS X [v2]

2021-03-20 Thread Phil Race
On Sat, 20 Mar 2021 14:01:51 GMT, Alexander Zuev wrote: >> 8263846: Bad JNI lookup getFocusOwner in accessibility code on Mac OS X > > Alexander Zuev has updated the pull request incrementally with one additional > commit since the last revision: > > Fixing accessibilityIndexOfChild in the

Re: RFR: 8263846: Bad JNI lookup getFocusOwner in accessibility code on Mac OS X [v2]

2021-03-20 Thread Phil Race
On Sat, 20 Mar 2021 13:57:21 GMT, Alexander Zuev wrote: >> src/java.desktop/macosx/native/libawt_lwawt/awt/JavaComponentAccessibility.m >> line 1459: >> >>> 1457: { >>> 1458: JNIEnv *env = [ThreadUtilities getJNIEnv]; >>> 1459: GET_CACCESSIBILITY_CLASS_RETURN(nil); >> >> Is it caused

Re: RFR: 8263846: Bad JNI lookup getFocusOwner in accessibility code on Mac OS X [v2]

2021-03-20 Thread Alexander Zuev
On Sat, 20 Mar 2021 02:13:46 GMT, Sergey Bylokhov wrote: >> Alexander Zuev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Fixing accessibilityIndexOfChild in the same way > >

Re: RFR: 8263846: Bad JNI lookup getFocusOwner in accessibility code on Mac OS X [v2]

2021-03-20 Thread Alexander Zuev
> 8263846: Bad JNI lookup getFocusOwner in accessibility code on Mac OS X Alexander Zuev has updated the pull request incrementally with one additional commit since the last revision: Fixing accessibilityIndexOfChild in the same way - Changes: - all:

Re: RFR: 8263846: Bad JNI lookup getFocusOwner in accessibility code on Mac OS X [v2]

2021-03-20 Thread Alexander Zuev
On Fri, 19 Mar 2021 23:41:34 GMT, Alexander Zvegintsev wrote: > Since there is no test, I assume that the JBS issue should have `noreg-hard` > label. Yes, as with most of platform-specific accessibility issues just configuring a system to be able to invoke this native functionality is quite

Re: RFR: 8263846: Bad JNI lookup getFocusOwner in accessibility code on Mac OS X

2021-03-19 Thread Sergey Bylokhov
On Fri, 19 Mar 2021 23:10:46 GMT, Alexander Zuev wrote: > 8263846: Bad JNI lookup getFocusOwner in accessibility code on Mac OS X src/java.desktop/macosx/native/libawt_lwawt/awt/JavaComponentAccessibility.m line 1459: > 1457: { > 1458: JNIEnv *env = [ThreadUtilities getJNIEnv]; > 1459:

Re: RFR: 8263846: Bad JNI lookup getFocusOwner in accessibility code on Mac OS X

2021-03-19 Thread Alexander Zvegintsev
On Fri, 19 Mar 2021 23:10:46 GMT, Alexander Zuev wrote: > 8263846: Bad JNI lookup getFocusOwner in accessibility code on Mac OS X Since there is no test, I assume that the JBS issue should have `noreg-hard` label. - Marked as reviewed by azvegint (Reviewer). PR:

RFR: 8263846: Bad JNI lookup getFocusOwner in accessibility code on Mac OS X

2021-03-19 Thread Alexander Zuev
8263846: Bad JNI lookup getFocusOwner in accessibility code on Mac OS X - Commit messages: - 8263846: Bad JNI lookup getFocusOwner in accessibility code on Mac OS X Changes: https://git.openjdk.java.net/jdk/pull/3099/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk=3099=00