Re: RFR: 8270116: Expand ButtonGroupLayoutTraversalTest.java to run in all LaFs, including Aqua on macOS [v2]

2021-08-05 Thread Alexey Ivanov
On Wed, 4 Aug 2021 21:43:53 GMT, rajat mahajan wrote: >> Summary: Expanded ButtonGroupLayoutTraversalTest.java to run in all LAFs on >> all OS. Added synchronization for focusCnt. > > rajat mahajan has updated the pull request incrementally with one additional > commit since the last

Re: RFR: 8270116: Expand ButtonGroupLayoutTraversalTest.java to run in all LaFs, including Aqua on macOS [v2]

2021-08-04 Thread Prasanta Sadhukhan
On Wed, 4 Aug 2021 21:43:53 GMT, rajat mahajan wrote: >> Summary: Expanded ButtonGroupLayoutTraversalTest.java to run in all LAFs on >> all OS. Added synchronization for focusCnt. > > rajat mahajan has updated the pull request incrementally with one additional > commit since the last

Re: RFR: 8270116: Expand ButtonGroupLayoutTraversalTest.java to run in all LaFs, including Aqua on macOS [v2]

2021-08-04 Thread rajat mahajan
On Wed, 4 Aug 2021 14:35:34 GMT, Alexey Ivanov wrote: >> I still think nx, ny should be made CAPS...It seems to be the case for >> static final constant variables in java/awt test folder...I don't think it >> will increase noise as it will impact only in l57 > > It will affect more lines;

Re: RFR: 8270116: Expand ButtonGroupLayoutTraversalTest.java to run in all LaFs, including Aqua on macOS [v2]

2021-08-04 Thread rajat mahajan
> Summary: Expanded ButtonGroupLayoutTraversalTest.java to run in all LAFs on > all OS. Added synchronization for focusCnt. rajat mahajan has updated the pull request incrementally with one additional commit since the last revision: make variables with static final modifier CAPS, as per

Re: RFR: 8270116: Expand ButtonGroupLayoutTraversalTest.java to run in all LaFs, including Aqua on macOS

2021-08-04 Thread Alexey Ivanov
On Wed, 4 Aug 2021 05:06:13 GMT, Prasanta Sadhukhan wrote: >> @prsadhuk I did what you asked, do you have any more questions or comments >> ?, if not could you please approve this PR, thanks. > > I still think nx, ny should be made CAPS...It seems to be the case for static > final constant

Re: RFR: 8270116: Expand ButtonGroupLayoutTraversalTest.java to run in all LaFs, including Aqua on macOS

2021-08-03 Thread Prasanta Sadhukhan
On Tue, 3 Aug 2021 18:30:09 GMT, rajat mahajan wrote: >> test/jdk/java/awt/Focus/FocusTraversalPolicy/ButtonGroupLayoutTraversal/ButtonGroupLayoutTraversalTest.java >> line 54: >> >>> 52: public class ButtonGroupLayoutTraversalTest { >>> 53: >>> 54: private static final int nx = 3; >>

Re: RFR: 8270116: Expand ButtonGroupLayoutTraversalTest.java to run in all LaFs, including Aqua on macOS

2021-08-03 Thread rajat mahajan
On Fri, 30 Jul 2021 05:35:58 GMT, Prasanta Sadhukhan wrote: >> Summary: Expanded ButtonGroupLayoutTraversalTest.java to run in all LAFs on >> all OS. Added synchronization for focusCnt. > >

Re: RFR: 8270116: Expand ButtonGroupLayoutTraversalTest.java to run in all LaFs, including Aqua on macOS

2021-07-30 Thread rajat mahajan
On Fri, 30 Jul 2021 05:35:58 GMT, Prasanta Sadhukhan wrote: >> Summary: Expanded ButtonGroupLayoutTraversalTest.java to run in all LAFs on >> all OS. Added synchronization for focusCnt. > >

Re: RFR: 8270116: Expand ButtonGroupLayoutTraversalTest.java to run in all LaFs, including Aqua on macOS

2021-07-30 Thread Alexey Ivanov
On Thu, 29 Jul 2021 20:29:31 GMT, rajat mahajan wrote: > Summary: Expanded ButtonGroupLayoutTraversalTest.java to run in all LAFs on > all OS. Added synchronization for focusCnt. Looks good to me. - Marked as reviewed by aivanov (Reviewer). PR:

Re: RFR: 8270116: Expand ButtonGroupLayoutTraversalTest.java to run in all LaFs, including Aqua on macOS

2021-07-29 Thread Prasanta Sadhukhan
On Thu, 29 Jul 2021 20:29:31 GMT, rajat mahajan wrote: > Summary: Expanded ButtonGroupLayoutTraversalTest.java to run in all LAFs on > all OS. Added synchronization for focusCnt. Also, please give a CI run of this test running for several iterations(20+) for all platforms since it's supposed