On Wed, 4 Aug 2021 21:43:53 GMT, rajat mahajan
wrote:
>> Summary: Expanded ButtonGroupLayoutTraversalTest.java to run in all LAFs on
>> all OS. Added synchronization for focusCnt.
>
> rajat mahajan has updated the pull request incrementally with one additional
> commit since the last
On Wed, 4 Aug 2021 21:43:53 GMT, rajat mahajan
wrote:
>> Summary: Expanded ButtonGroupLayoutTraversalTest.java to run in all LAFs on
>> all OS. Added synchronization for focusCnt.
>
> rajat mahajan has updated the pull request incrementally with one additional
> commit since the last
On Wed, 4 Aug 2021 14:35:34 GMT, Alexey Ivanov wrote:
>> I still think nx, ny should be made CAPS...It seems to be the case for
>> static final constant variables in java/awt test folder...I don't think it
>> will increase noise as it will impact only in l57
>
> It will affect more lines;
> Summary: Expanded ButtonGroupLayoutTraversalTest.java to run in all LAFs on
> all OS. Added synchronization for focusCnt.
rajat mahajan has updated the pull request incrementally with one additional
commit since the last revision:
make variables with static final modifier CAPS, as per
On Wed, 4 Aug 2021 05:06:13 GMT, Prasanta Sadhukhan
wrote:
>> @prsadhuk I did what you asked, do you have any more questions or comments
>> ?, if not could you please approve this PR, thanks.
>
> I still think nx, ny should be made CAPS...It seems to be the case for static
> final constant
On Tue, 3 Aug 2021 18:30:09 GMT, rajat mahajan
wrote:
>> test/jdk/java/awt/Focus/FocusTraversalPolicy/ButtonGroupLayoutTraversal/ButtonGroupLayoutTraversalTest.java
>> line 54:
>>
>>> 52: public class ButtonGroupLayoutTraversalTest {
>>> 53:
>>> 54: private static final int nx = 3;
>>
On Fri, 30 Jul 2021 05:35:58 GMT, Prasanta Sadhukhan
wrote:
>> Summary: Expanded ButtonGroupLayoutTraversalTest.java to run in all LAFs on
>> all OS. Added synchronization for focusCnt.
>
>
On Fri, 30 Jul 2021 05:35:58 GMT, Prasanta Sadhukhan
wrote:
>> Summary: Expanded ButtonGroupLayoutTraversalTest.java to run in all LAFs on
>> all OS. Added synchronization for focusCnt.
>
>
On Thu, 29 Jul 2021 20:29:31 GMT, rajat mahajan
wrote:
> Summary: Expanded ButtonGroupLayoutTraversalTest.java to run in all LAFs on
> all OS. Added synchronization for focusCnt.
Looks good to me.
-
Marked as reviewed by aivanov (Reviewer).
PR:
On Thu, 29 Jul 2021 20:29:31 GMT, rajat mahajan
wrote:
> Summary: Expanded ButtonGroupLayoutTraversalTest.java to run in all LAFs on
> all OS. Added synchronization for focusCnt.
Also, please give a CI run of this test running for several iterations(20+) for
all platforms since it's supposed
10 matches
Mail list logo