> Collections.sort is just a wrapper, so it is better to use an instance method
> directly.
Andrey Turbanov has refreshed the contents of this pull request, and previous
commits have been removed. The incremental views will show differences compared
to the previous content of the PR.
-
On Wed, 25 Aug 2021 12:47:41 GMT, Andrey Turbanov
wrote:
>> src/java.base/share/classes/java/net/URLPermission.java line 222:
>>
>>> 220:
>>> 221: List l = normalizeMethods(methods);
>>> 222: l.sort(null);
>>
>> I am not opposed to this change, but I find this is slightly more
On Wed, 25 Aug 2021 08:29:57 GMT, Daniel Fuchs wrote:
>> Andrey Turbanov has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8272863: Replace usages of Collections.sort with List.sort call in public
>> java modules
>> replace Collections.
On Tue, 24 Aug 2021 20:21:52 GMT, Andrey Turbanov
wrote:
>> Collections.sort is just a wrapper, so it is better to use an instance
>> method directly.
>
> Andrey Turbanov has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8272863: Replace us
On Tue, 24 Aug 2021 11:48:46 GMT, Alexander Zvegintsev
wrote:
> Is there any reason to not touch them along with this fix?
Update them too.
-
PR: https://git.openjdk.java.net/jdk/pull/5229
> Collections.sort is just a wrapper, so it is better to use an instance method
> directly.
Andrey Turbanov has updated the pull request incrementally with one additional
commit since the last revision:
8272863: Replace usages of Collections.sort with List.sort call in public
java modules
On Mon, 23 Aug 2021 21:01:48 GMT, Andrey Turbanov
wrote:
> Collections.sort is just a wrapper, so it is better to use an instance method
> directly.
java.time changes look good.
-
Marked as reviewed by naoto (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/5229
On Mon, 23 Aug 2021 21:01:48 GMT, Andrey Turbanov
wrote:
> Collections.sort is just a wrapper, so it is better to use an instance method
> directly.
There are a bunch of calls to `Collections.sort()` without a comparator
specified (at least in java.desktop):
https://github.com/openjdk/jdk/b
On Mon, 23 Aug 2021 21:01:48 GMT, Andrey Turbanov
wrote:
> Collections.sort is just a wrapper, so it is better to use an instance method
> directly.
java/net and sun/net changes LGTM
-
Marked as reviewed by dfuchs (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/5229
On Mon, 23 Aug 2021 21:01:48 GMT, Andrey Turbanov
wrote:
> Collections.sort is just a wrapper, so it is better to use an instance method
> directly.
The changes in the src/java.desktop/ looks fine.
Filed: https://bugs.openjdk.java.net/browse/JDK-8272863
-
Marked as reviewed by s
Collections.sort is just a wrapper, so it is better to use an instance method
directly.
-
Commit messages:
- [PATCH] Replace usages of Collections.sort with List.sort call in public
java modules
Changes: https://git.openjdk.java.net/jdk/pull/5229/files
Webrev: https://webrevs.ope
11 matches
Mail list logo
