On 07/10/16 19:40, Philip Race wrote:
You are looking at the wrong forest.
All client changes must always go to
http://hg.openjdk.java.net/jdk9/client.
Ah, right. Will that end up in dev eventually? I haven't found anything
so far that explains the relationships between all the repo
You are looking at the wrong forest.
All client changes must always go to http://hg.openjdk.java.net/jdk9/client.
-phil.
On 10/7/16, 11:35 AM, Alan Burlison wrote:
On 06/10/2016 22:26, Alan Burlison wrote:
Oh .. Alan see you already did exactly that :-). So we are in
agreement there.
Yes,
On 06/10/2016 22:26, Alan Burlison wrote:
Oh .. Alan see you already did exactly that :-). So we are in
agreement there.
Yes, seen the push - thanks :-)
I'll check with a fresh clone tomorrow but I *think* with this committed
Java9 now builds cleanly on Solaris 12. Yay! :-)
Hmm, I've just
On 06/10/2016 19:38, Phil Race wrote:
PS I am going to change the bug synopsis since otherwise we'll be
committing to the mercurial history something which is different than
what we actually did. I'll just truncate it to "XKeycodeToKeysym is
deprecated and should be replaced"
Oh .. Alan see
On 06/10/2016 19:32, Phil Race wrote:
.. and Alan I did suggest last time that the updated webrev be a ".1" as
in place replacement loses history and context for people who aren't
reading the email thread "live".
Oops, sorry you did say that and I forgot this time round - apologies.
--
Alan
PS I am going to change the bug synopsis since otherwise we'll be committing
to the mercurial history something which is different than what we
actually did.
I'll just truncate it to "XKeycodeToKeysym is deprecated and should be
replaced"
Oh .. Alan see you already did exactly that :-). So we
+1
.. and Alan I did suggest last time that the updated webrev be a ".1" as
in place replacement loses history and context for people who aren't
reading the email thread "live".
I'll push this for Alan since I think he asked for that help ..
-phil.
On 10/06/2016 11:21 AM, Alexander
+1
P.S. It wasn't hard to find, but the webrev is updated at the first
revision http://cr.openjdk.java.net/~alanbur/JDK-8165232
--
Thanks,
Alexander.
On 06.10.2016 13:18, Alan Burlison wrote:
On 04/10/2016 19:34, Alan Burlison wrote:
key_syms is not freed.
So there is, thanks for the
On 04/10/2016 19:34, Alan Burlison wrote:
key_syms is not freed.
So there is, thanks for the catch.
Done, webrev updated, jprt -tset hostpot rerun & clean.
--
Alan Burlison
--
On 04/10/16 17:34, Alexander Zvegintsev wrote:
as I can see there is a memory leak in case when the index is greater
than or equal to num_syms:
837 KeySym *key_syms = XGetKeyboardMapping(display, keycode, 1, _syms);
838 if (index >= num_syms) {
839 return NoSymbol;
840 }
key_syms is not
Hello,
as I can see there is a memory leak in case when the index is greater
than or equal to num_syms:
837 KeySym *key_syms = XGetKeyboardMapping(display, keycode, 1, _syms);
838 if (index >= num_syms) {
839 return NoSymbol;
840 }
key_syms is not freed.
--
Thanks,
Alexander.
On 10/4/16
On 03/10/2016 22:08, Phil Race wrote:
Do we have a 2nd reviewer yet ? I have not seen it.
Gah you are right, I thought I'd seen a 2nd. Any takers?
--
Alan Burlison
--
Do we have a 2nd reviewer yet ? I have not seen it.
-phil.
On 10/03/2016 08:21 AM, Alan Burlison wrote:
On 30/09/2016 20:01, Phil Race wrote:
Our helpful SQE engineer has verified that this works as well as
previously.
And I've done some basic testing myself on Ubuntu 16.04, so "+1"
(meaning
On 30/09/2016 20:01, Phil Race wrote:
Our helpful SQE engineer has verified that this works as well as
previously.
And I've done some basic testing myself on Ubuntu 16.04, so "+1"
(meaning approved).
Thanks. Could someone sponsor this for me?
--
Alan Burlison
--
Our helpful SQE engineer has verified that this works as well as previously.
And I've done some basic testing myself on Ubuntu 16.04, so "+1"
(meaning approved).
-phil.
On 09/27/2016 08:41 AM, Alan Burlison wrote:
On 26/09/2016 23:42, Philip Race wrote:
So that looks like it should work
On 27/09/2016 16:41, Alan Burlison wrote:
Done, new webrev at http://cr.openjdk.java.net/~alanbur/JDK-8165232.v2/
Does this look OK?
--
Alan Burlison
--
On 26/09/2016 23:42, Philip Race wrote:
So that looks like it should work although the duplicate
definition irks. Can we remove the static and have it just be
extern declared in XWindow.c ?
Absolutely - I didn't particularly like it either but I was a bit
wary of adding a new external
On 9/26/16, 3:09 PM, Alan Burlison wrote:
On 26/09/16 23:01, Philip Race wrote:
So that looks like it should work although the duplicate definition
irks.
Can we remove the static and have it just be extern declared in
XWindow.c ?
Absolutely - I didn't particularly like it either but I was
On 26/09/16 23:01, Philip Race wrote:
So that looks like it should work although the duplicate definition irks.
Can we remove the static and have it just be extern declared in XWindow.c ?
Absolutely - I didn't particularly like it either but I was a bit wary
of adding a new external symbol.
So that looks like it should work although the duplicate definition irks.
Can we remove the static and have it just be extern declared in XWindow.c ?
For testing can you submit a jprt job and I'll see if I can rustle up some
SQE support to identify any tests that might be good to run.
-phil.
On 25/09/2016 01:04, Philip Race wrote:
94 KeySym *key_syms = XGetKeyboardMapping(display, keycode, index
+ 1,_syms);
I might be mis-reading the API but the docs as I read it have argument 3
as a count .. so it should be 1 here, should it not ?
94 KeySym *key_syms = XGetKeyboardMapping(display, keycode, index +
1,_syms);
I might be mis-reading the API but the docs as I read it have argument 3
as a count .. so it should be 1 here, should it not ?
https://tronche.com/gui/x/xlib/input/XGetKeyboardMapping.html
As written I have a
On 06/09/2016 11:16, Alan Burlison wrote:
XKeycodeToKeysym is deprecated and when compiled on Solaris 12 with
warnings-as-errors this causes a compile time failure. References to
XKeycodeToKeysym should be replaced by XkbKeycodeToKeysym. As this is
common XOrg code it will affect Linux as well.
On 06/09/2016 21:42, Phil Race wrote:
These are all internal-only entry points So if that exists (I did not
know that it did) then I think you have a few options but the most
forward looking is to get rid of all references to the deprecated
methods and migrate all uses (inc. Java land ones) to
On 06/09/2016 22:03, Alan Burlison wrote:
Thanks for the detail, doing as you suggest and migrating all the
references seems like the best approach as it shouldn't require any
followup work in the future. I'll make the changes you've suggested,
retest and post an updated webrev when I've done
On 06/09/2016 21:42, Phil Race wrote:
These are all internal-only entry points So if that exists (I did not
know that it did) then I think you have a few options but the most
forward looking is to get rid of all references to the deprecated
methods and migrate all uses (inc. Java land ones) to
On 9/6/2016 1:14 PM, Alan Burlison wrote:
On 06/09/2016 20:29, Phil Race wrote:
You are removing this : native method
Java_sun_awt_X11_XlibWrapper_XKeycodeToKeysym There is no explanation
about this .. and unless you discovered this method is obsolete (never
called) it seems like it should
On 06/09/2016 20:29, Phil Race wrote:
You are removing this : native method
Java_sun_awt_X11_XlibWrapper_XKeycodeToKeysym There is no explanation
about this .. and unless you discovered this method is obsolete (never
called) it seems like it should also be updated .. not deleted. And
since I
Alan,
You are removing this : native method
Java_sun_awt_X11_XlibWrapper_XKeycodeToKeysym There is no explanation
about this .. and unless you discovered this method is obsolete (never
called) it seems like it should also be updated .. not deleted. And
since I see it called from
XKeycodeToKeysym is deprecated and when compiled on Solaris 12 with
warnings-as-errors this causes a compile time failure. References to
XKeycodeToKeysym should be replaced by XkbKeycodeToKeysym. As this is
common XOrg code it will affect Linux as well.
Bug:
XKeycodeToKeysym is deprecated and when compiled on Solaris 12 with
warnings-as-errors this causes a compile time failure. References to
XKeycodeToKeysym should be replaced by XkbKeycodeToKeysym. As this is
common XOrg code it will affect Linux as well.
Bug:
31 matches
Mail list logo
