Re: RFR: JDK-8215296 do not disable c99 on Solaris

On 2018-12-14 12:49, Magnus Ihse Bursie wrote: 13 dec. 2018 kl. 19:07 skrev Erik Joelsson >: On 2018-12-13 02:11, Magnus Ihse Bursie wrote: -D_XPG6 ?? To be honest, I'm not completely sure about this. Without this define, the build failed with the fol

Re: RFR: JDK-8215296 do not disable c99 on Solaris

13 dec. 2018 kl. 19:07 skrev Erik Joelsson >: On 2018-12-13 02:11, Magnus Ihse Bursie wrote: -D_XPG6 ?? To be honest, I'm not completely sure about this. Without this define, the build failed with the following error message: Compiler or options invalid f

Re: [OpenJDK 2D-Dev] RFR: JDK-8215296 do not disable c99 on Solaris

On 12/13/18 10:07 AM, Erik Joelsson wrote:  * These macros only have an effect if the operating system supports either  * POSIX 1003.1 or C99, or both.  On other operating systems (particularly  * Windows/Visual Studio) there is no effect; the OS specific tests below are  * still required (

Re: RFR: JDK-8215296 do not disable c99 on Solaris

On 2018-12-13 02:11, Magnus Ihse Bursie wrote: -D_XPG6 ?? To be honest, I'm not completely sure about this. Without this define, the build failed with the following error message: Compiler or options invalid for pre-UNIX 03 X/Open applications and pre-2001 POSIX applications This was tri

Re: RFR: JDK-8215296 do not disable c99 on Solaris

On 2018-12-12 23:17, David Holmes wrote: Hi Magnus, What did -Xa do? I believe Kim has answered this satisfactory. Do AWT folk need to check this. I'm adding awt and 2d lists to this review. I find it hard to understand the connection between: I'm not sure there is a connection..? It's t