Re: RFR: Support GNOME Shell as mutter

2013-09-16 Thread Omair Majid
Hi Anthony, On 09/16/2013 03:32 PM, Anthony Petrov wrote: > Alexander doesn't have an OpenJDK id yet. But still, having an > additional review never hurts. Agreed, the more reviewers the better :) > Please feel free to push the fix listing only me as a reviewer, and let > me know if you need any

Re: RFR: Support GNOME Shell as mutter

2013-09-16 Thread Anthony Petrov
Hi Omair, Alexander doesn't have an OpenJDK id yet. But still, having an additional review never hurts. Please feel free to push the fix listing only me as a reviewer, and let me know if you need any assistance with this. -- best regards, Anthony On 09/16/2013 08:59 PM, Omair Majid wrote:

Re: RFR: Support GNOME Shell as mutter

2013-09-16 Thread Omair Majid
On 09/16/2013 10:02 AM, Anthony Petrov wrote: > Hi Omair, > > Thanks for the patch. Looks fine to me. I've just filed a bug for this fix: > > 8024863: X11: Support GNOME Shell as mutter Thanks for the review! > Do you have commit rights for the awt-gate, or do you want me to push > the fix for

Re: RFR: Support GNOME Shell as mutter

2013-09-16 Thread Omair Majid
Hi Alexander, On 09/16/2013 10:27 AM, Alexander Zvegintsev wrote: > The patch looks fine to me. Thanks for the review! I wanted to credit you in the Reviewed-by line of the commit message, but I cant find you in the census: http://openjdk.java.net/census Thanks, Omair -- PGP Key: 66484681 (htt

Re: RFR: Support GNOME Shell as mutter

2013-09-16 Thread Alexander Zvegintsev
Hi Omair, The patch looks fine to me. Thanks, Alexander. On 09/16/2013 01:45 AM, Omair Majid wrote: On 09/08/2013 04:11 PM, Omair Majid wrote: Hi, With recent versions of GNOME shell, GNOME shell sets the _NET_WM_NAME to "GNOME Shell" instead of mutter. It's still mutter that's running, but

Re: RFR: Support GNOME Shell as mutter

2013-09-16 Thread Anthony Petrov
Hi Omair, Thanks for the patch. Looks fine to me. I've just filed a bug for this fix: 8024863: X11: Support GNOME Shell as mutter Do you have commit rights for the awt-gate, or do you want me to push the fix for you? -- best regards, Anthony On 09/16/13 01:45, Omair Majid wrote: On 09/08/2

Re: RFR: Support GNOME Shell as mutter

2013-09-15 Thread Omair Majid
On 09/08/2013 04:11 PM, Omair Majid wrote: > Hi, > > With recent versions of GNOME shell, GNOME shell sets the _NET_WM_NAME > to "GNOME Shell" instead of mutter. It's still mutter that's running, > but with a different _NET_WM_NAME. > > The following webrev makes OpenJDK compatible with these new

RFR: Support GNOME Shell as mutter

2013-09-08 Thread Omair Majid
Hi, With recent versions of GNOME shell, GNOME shell sets the _NET_WM_NAME to "GNOME Shell" instead of mutter. It's still mutter that's running, but with a different _NET_WM_NAME. The following webrev makes OpenJDK compatible with these newer versions: http://cr.openjdk.java.net/~omajid/webrevs/n