Re: RFR [9] Modular Source Code

2014-08-29 Thread Magnus Ihse Bursie
On 2014-08-28 21:36, Phil Race wrote: >./windows/native/libawt/sun/java2d/d3d/D3DShaderGen.c Is a tool that is run manually when we need to re-generate the shaders. It is co-located so that can be found easily. It certainly should not be deleted, nor should it be moved anywhere obscure. Oh,

Re: [OpenJDK 2D-Dev] RFR [9] Modular Source Code

2014-08-29 Thread Magnus Ihse Bursie
On 2014-08-28 21:40, Phil Race wrote: On 8/28/2014 12:36 PM, Phil Race wrote: * All of the awt-related directories (libawt_* and common) include an unnecessary extra layer, the "sun" directory. It is not needed anymore, Let's *not* do that. It also affects the destination package. Remember sun

Re: RFR [9] Modular Source Code

2014-08-28 Thread Alan Bateman
On 28/08/2014 20:36, Phil Race wrote: * All of the awt-related directories (libawt_* and common) include an unnecessary extra layer, the "sun" directory. It is not needed anymore, Let's *not* do that. It also affects the destination package. Remember sun.* is the protected top-level package ..

Re: [OpenJDK 2D-Dev] RFR [9] Modular Source Code

2014-08-28 Thread Phil Race
On 8/28/2014 12:36 PM, Phil Race wrote: * All of the awt-related directories (libawt_* and common) include an unnecessary extra layer, the "sun" directory. It is not needed anymore, Let's *not* do that. It also affects the destination package. Remember sun.* is the protected top-level package .

Re: RFR [9] Modular Source Code

2014-08-28 Thread Phil Race
* All of the awt-related directories (libawt_* and common) include an unnecessary extra layer, the "sun" directory. It is not needed anymore, Let's *not* do that. It also affects the destination package. Remember sun.* is the protected top-level package .. and people won't always be running in j

Re: RFR [9] Modular Source Code

2014-08-28 Thread Anthony Petrov
Thanks! -- best regards, Anthony On 8/28/2014 1:00 PM, Magnus Ihse Bursie wrote: On 2014-08-27 12:57, Anthony Petrov wrote: Hi Magnus, Those look like reasonable suggestions. Could you please file separate bugs for each of these issues? Also, please note that most of them belong to 2D, not AW

Re: RFR [9] Modular Source Code

2014-08-28 Thread Magnus Ihse Bursie
On 2014-08-27 12:57, Anthony Petrov wrote: Hi Magnus, Those look like reasonable suggestions. Could you please file separate bugs for each of these issues? Also, please note that most of them belong to 2D, not AWT (e.g. the font-, color-, d3d-, and opengl-related files) even though they're co

Re: RFR [9] Modular Source Code

2014-08-27 Thread Alan Bateman
On 27/08/2014 11:57, Anthony Petrov wrote: Hi Magnus, Those look like reasonable suggestions. Could you please file separate bugs for each of these issues? Also, please note that most of them belong to 2D, not AWT (e.g. the font-, color-, d3d-, and opengl-related files) even though they're co

Re: RFR [9] Modular Source Code

2014-08-27 Thread Anthony Petrov
Hi Magnus, Those look like reasonable suggestions. Could you please file separate bugs for each of these issues? Also, please note that most of them belong to 2D, not AWT (e.g. the font-, color-, d3d-, and opengl-related files) even though they're compiled into the awt native libraries. -- b

Re: RFR [9] Modular Source Code

2014-08-25 Thread Magnus Ihse Bursie
On 2014-08-20 11:14, Magnus Ihse Bursie wrote: On 2014-08-18 16:15, Anthony Petrov wrote: So I'm not sure if the current set of AWT libraries could be simplified any further. Hope this helps. Thank you for the clarification, it was very helpful! While the set of AWT libraries probably canno

Re: RFR [9] Modular Source Code

2014-08-20 Thread Magnus Ihse Bursie
On 2014-08-18 16:15, Anthony Petrov wrote: On 8/18/2014 5:47 PM, Magnus Ihse Bursie wrote: libawt et al: The relation between libawt, libawt_headless, libjawt, libawt_xawt and libawt_lwawt are hairy enough to make my brain curl up. I believe there are simplifications to be made but I gave up

Re: RFR [9] Modular Source Code

2014-08-20 Thread Erik Joelsson
Hello, The basic rule for the new source layout is that for each library, there is a directory where all sources for that library go. This was hard to apply to libawt and friends since as you say, some files go in libawt on windows and libawt_xawt on linux and solaris. For now, I put those in

Re: RFR [9] Modular Source Code

2014-08-19 Thread Phil Race
On a related note I am scratching my head about why some files destined to be compiled into libawt or libawt_xawt go into a directory called 'common'. Eg OpenGL sources are in common but aren't common to all libs or even to all awt libs, since they would go into libawt on windows and libawt_xawt o

Re: RFR [9] Modular Source Code

2014-08-18 Thread Anthony Petrov
On 8/18/2014 5:47 PM, Magnus Ihse Bursie wrote: libawt et al: The relation between libawt, libawt_headless, libjawt, libawt_xawt and libawt_lwawt are hairy enough to make my brain curl up. I believe there are simplifications to be made but I gave up trying to figure them out. libawt contains