Re: Review request for 8143064 Icons are not properly rendered with Windows L&F on HiDPI display

2016-08-02 Thread Sergey Bylokhov
Hi, Alex. I have a few questions about the fix: - I am not sure that tx.getScaleX/tx.getScaleY can be used in this context, because this is not a default transform of GDevice(which can be scaled only), but transform of graphics which can have translate/scale/rotate. Probably we should not take

Re: Review request for 8143064 Icons are not properly rendered with Windows L&F on HiDPI display

2016-07-08 Thread Semyon Sadetsky
On 7/8/2016 2:28 PM, Alexandr Scherbatiy wrote: On 7/7/2016 9:11 PM, Semyon Sadetsky wrote: Caching works. Icon sizes are correct as well. Why the check box image doesn't change its size with the scale? Only margins are growing. Is it expected behavior? Screenshot [1] shows checkboxes for t

Re: Review request for 8143064 Icons are not properly rendered with Windows L&F on HiDPI display

2016-07-08 Thread Alexandr Scherbatiy
On 7/7/2016 9:11 PM, Semyon Sadetsky wrote: Caching works. Icon sizes are correct as well. Why the check box image doesn't change its size with the scale? Only margins are growing. Is it expected behavior? Screenshot [1] shows checkboxes for the native control, java checkbox with the fix and

Re: Review request for 8143064 Icons are not properly rendered with Windows L&F on HiDPI display

2016-07-07 Thread Semyon Sadetsky
Caching works. Icon sizes are correct as well. Why the check box image doesn't change its size with the scale? Only margins are growing. Is it expected behavior? --Semyon On 05.07.2016 16:53, Alexandr Scherbatiy wrote: Could you review the updated fix: http://cr.openjdk.java.net/~alexsch/8

Re: Review request for 8143064 Icons are not properly rendered with Windows L&F on HiDPI display

2016-07-05 Thread Alexandr Scherbatiy
Could you review the updated fix: http://cr.openjdk.java.net/~alexsch/8143064/webrev.02 - the PainterMultiResolutionCachedImage.getWidth()/getHeight() methods are overridden to not call the base resolution variant - scale factors are added to the multi-resolution image - component and args a

Re: Review request for 8143064 Icons are not properly rendered with Windows L&F on HiDPI display

2016-06-30 Thread Semyon Sadetsky
Hi Alexander, I have added printout after the line 679 of the XPStyle.java: 676 ThemeReader.paintBackground(SunWritableRaster.stealData(dbi, 0), 677part.getControlName(c), part.getValue(), 678State.getValue(part, s

Re: Review request for 8143064 Icons are not properly rendered with Windows L&F on HiDPI display

2016-06-29 Thread Alexandr Scherbatiy
Hello, Could you review the updated fix: http://cr.openjdk.java.net/~alexsch/8143064/webrev.01 The MultiResolutionImage image is used for the icons painting. Thanks, Alexandr. On 11/16/2015 7:07 PM, Sergey Bylokhov wrote: Hi, Alexander. 109 AffineTransform tx = ((Graphics2D) g).ge

Review request for 8143064 Icons are not properly rendered with Windows L&F on HiDPI display

2015-11-17 Thread Alexander Scherbatiy
Hello, Could you review the fix: bug: https://bugs.openjdk.java.net/browse/JDK-8143064 webrev: http://cr.openjdk.java.net/~alexsch/8143064/webrev.00 Icon image sizes are scaled in sun.swing.CachedPainter. Thanks, Alexandr.

Re: Review request for 8143064 Icons are not properly rendered with Windows L&F on HiDPI display

2015-11-16 Thread Sergey Bylokhov
Hi, Alexander. 109 AffineTransform tx = ((Graphics2D) g).getTransform(); 110 int sw = tx.isIdentity() ? w : (int) Math.round(w * tx.getScaleX()); 111 int sh = tx.isIdentity() ? h : (int) Math.round(h * tx.getScaleY()); I think that it is not necessary that !isIdentit