Re: Review request for 8143316 Crash Trend in 1.9.0-ea-b93 (sun.awt.DefaultMouseInfoPeer.fillPointWithCoords)

2015-12-30 Thread Sergey Bylokhov
Looks fine. On 28/12/15 17:47, Alexander Scherbatiy wrote: Could you review the updated fix: http://cr.openjdk.java.net/~alexsch/8143316/webrev.01 - DefaultMouseInfoPeer is removed from the SunToolkit and WMouseInfoPeer is added to the WToolkit - Screen devices initialization is added

Re: Review request for 8143316 Crash Trend in 1.9.0-ea-b93 (sun.awt.DefaultMouseInfoPeer.fillPointWithCoords)

2015-12-28 Thread Alexander Scherbatiy
Could you review the updated fix: http://cr.openjdk.java.net/~alexsch/8143316/webrev.01 - DefaultMouseInfoPeer is removed from the SunToolkit and WMouseInfoPeer is added to the WToolkit - Screen devices initialization is added to the WMouseInfoPeer - MONITOR_DEFAULTTONEAREST argument is

Re: Review request for 8143316 Crash Trend in 1.9.0-ea-b93 (sun.awt.DefaultMouseInfoPeer.fillPointWithCoords)

2015-12-23 Thread Sergey Bylokhov
Hi. This issue is related to windows only, but we change the shared code in a way which can mislead someone, and the crash can be returned after some refactoring, or when someone will call fillPointWithCoords() before device initialization in some other place. So it seems this code should be re

Review request for 8143316 Crash Trend in 1.9.0-ea-b93 (sun.awt.DefaultMouseInfoPeer.fillPointWithCoords)

2015-12-10 Thread Alexander Scherbatiy
Hello, Could you review the fix: bug: https://bugs.openjdk.java.net/browse/JDK-8143316 webrev: http://cr.openjdk.java.net/~alexsch/8143316/webrev.00 The the native MouseInfo.fillPointWithCoords() method can access the devices before they are initialized. The fix moves the devices initi