Re: Review request for 8151385: [hidpi] JOptionPane-Icons only partially visible when using Windows 10 L

2016-06-14 Thread Alexandr Scherbatiy
The fix looks good to me. Thanks, Alexandr. On 6/9/2016 12:43 PM, Sergey Bylokhov wrote: +1 On 08.06.16 10:57, Hendrik Schreiber wrote: Hey Alexandr, On Jun 7, 2016, at 17:44, Alexandr Scherbatiy wrote: I slightly updated your fix to return a

Re: Review request for 8151385: [hidpi] JOptionPane-Icons only partially visible when using Windows 10 L

2016-06-09 Thread Sergey Bylokhov
+1 On 08.06.16 10:57, Hendrik Schreiber wrote: Hey Alexandr, On Jun 7, 2016, at 17:44, Alexandr Scherbatiy wrote: I slightly updated your fix to return a multi-resolution image with base icon size when icon size is greater than the real icon size. This

Re: Review request for 8151385: [hidpi] JOptionPane-Icons only partially visible when using Windows 10 L

2016-06-08 Thread Hendrik Schreiber
Hey Alexandr, > On Jun 7, 2016, at 17:44, Alexandr Scherbatiy > wrote: > > I slightly updated your fix to return a multi-resolution image with base icon > size when icon size is greater than the real icon size. This allows to draw a > high-resolution icon to

Re: Review request for 8151385: [hidpi] JOptionPane-Icons only partially visible when using Windows 10 L

2016-06-07 Thread Alexandr Scherbatiy
Hello Hendrik, I slightly updated your fix to return a multi-resolution image with base icon size when icon size is greater than the real icon size. This allows to draw a high-resolution icon to the same bounds on JOptionPane.

Re: Review request for 8151385: [hidpi] JOptionPane-Icons only partially visible when using Windows 10 L

2016-03-22 Thread Alexandr Scherbatiy
On 3/22/2016 8:36 AM, Hendrik Schreiber wrote: On Mar 21, 2016, at 22:07, Alexandr Scherbatiy > wrote: On 3/18/2016 6:09 AM, Hendrik Schreiber wrote: On Mar 16, 2016, at 06:25, Alexandr Scherbatiy

Re: Review request for 8151385: [hidpi] JOptionPane-Icons only partially visible when using Windows 10 L

2016-03-22 Thread Hendrik Schreiber
> On Mar 21, 2016, at 22:07, Alexandr Scherbatiy > wrote: > > On 3/18/2016 6:09 AM, Hendrik Schreiber wrote: >> On Mar 16, 2016, at 06:25, Alexandr Scherbatiy < >> alexandr.scherba...@oracle.com >>

Re: Review request for 8151385: [hidpi] JOptionPane-Icons only partially visible when using Windows 10 L

2016-03-21 Thread Alexandr Scherbatiy
On 3/18/2016 6:09 AM, Hendrik Schreiber wrote: On Mar 16, 2016, at 06:25, Alexandr Scherbatiy > wrote: The JDK fixes should be pushed to the JDK 9 first and then be back-ported to JDK 8. Could you prepare the fix

Re: Review request for 8151385: [hidpi] JOptionPane-Icons only partially visible when using Windows 10 L

2016-03-19 Thread Hendrik Schreiber
On Mar 16, 2016, at 06:25, Alexandr Scherbatiy wrote: > > > The JDK fixes should be pushed to the JDK 9 first and then be back-ported > to JDK 8. > > Could you prepare the fix for JDK 9? Hi Alexandr, I've created a patch for JDK9. You can find it at

Re: Review request for 8151385: [hidpi] JOptionPane-Icons only partially visible when using Windows 10 L

2016-03-12 Thread Hendrik Schreiber
Thanks, Alexander. Can you also review it? -hendrik > On Mar 11, 2016, at 19:06, Alexander Scherbatiy > wrote: > > > I have uploaded the webrev to the cr.openjdk.java.net: > http://cr.openjdk.java.net/~alexsch/hendrik.schreiber/8151385/webrev.00/ >

Re: Review request for 8151385: [hidpi] JOptionPane-Icons only partially visible when using Windows 10 L

2016-03-11 Thread Hendrik Schreiber
Hey there, I would very much appreciate a review (and a sponsor) for this JDK 8u fix. Thanks so much! -hendrik > On Mar 7, 2016, at 16:47, Hendrik Schreiber wrote: > > Hey there, > > Could someone please review this fix for JDK8u. > > Bug: >

Review request for 8151385: [hidpi] JOptionPane-Icons only partially visible when using Windows 10 L

2016-03-07 Thread Hendrik Schreiber
Hey there, Could someone please review this fix for JDK8u. Bug: https://bugs.openjdk.java.net/browse/JDK-8151385 Webrev: https://www.beatunes.com/download/webrev-8151385.zip Issue: On