Re: Review request for JDK-8043131: Move ShapedAndTranslucentWindows and GC functional AWT tests to regression tree

2014-11-10 Thread Dmitriy Ermashov
These tests have been failing previously: java/awt/Window/ShapedAndTranslucentWindows/FocusAWTTest.java java/awt/Window/ShapedAndTranslucentWindows/SetShapeAndClick.java java/awt/Window/ShapedAndTranslucentWindows/SetShapeDynamicallyAndClick.java java/awt/Window/ShapedAndTranslucentWindows/ShapedT

Re: Review request for JDK-8043131: Move ShapedAndTranslucentWindows and GC functional AWT tests to regression tree

2014-11-07 Thread Sergey Bylokhov
On 07.11.2014 12:48, Dmitriy Ermashov wrote: Hi Sergey, Most of them fails on OS X 10.10 because of https://bugs.openjdk.java.net/browse/JDK-8013450. java/awt/Window/ShapedAndTranslucentWindows/FocusAWTTest.java test is marked with corresponding @bug tag. Others fails because of different sh

Re: Review request for JDK-8043131: Move ShapedAndTranslucentWindows and GC functional AWT tests to regression tree

2014-11-07 Thread Dmitriy Ermashov
Hi Sergey, Most of them fails on OS X 10.10 because of https://bugs.openjdk.java.net/browse/JDK-8013450. java/awt/Window/ShapedAndTranslucentWindows/FocusAWTTest.java test is marked with corresponding @bug tag. Others fails because of different shadows rendering on new OS X and should be fix

Re: Review request for JDK-8043131: Move ShapedAndTranslucentWindows and GC functional AWT tests to regression tree

2014-10-31 Thread Sergey Bylokhov
Hi, Dmitriy. These tests were passed on all platforms without problems? On 04.06.2014 11:46, Dmitriy Ermashov wrote: Hi Petr, all, Please review next revision of webrev: http://cr.openjdk.java.net/~yan/8043131/webrev.02/ 1. Set -Xmx20m key for GC tests 2. Added @Override annotation for all cor

Re: Review request for JDK-8043131: Move ShapedAndTranslucentWindows and GC functional AWT tests to regression tree

2014-06-23 Thread Dmitriy Ermashov
Hi, Just a kindly reminder. Please, review the changeset. Thanks, Dima 11.06.14, 10:57 пользователь "Dmitriy Ermashov" написал: >Petr, thanks for review! > >Sergey, could you please look at the fix? >http://cr.openjdk.java.net/~yan/8043131/webrev.02/ >You had some notices for the previous bug

Re: Review request for JDK-8043131: Move ShapedAndTranslucentWindows and GC functional AWT tests to regression tree

2014-06-10 Thread Dmitriy Ermashov
Petr, thanks for review! Sergey, could you please look at the fix? http://cr.openjdk.java.net/~yan/8043131/webrev.02/ You had some notices for the previous bug 8041915 (http://mail.openjdk.java.net/pipermail/awt-dev/2014-June/007944.html) Thanks, Dima On 04.06.2014 12:00, Petr Pchelko wrote:

Re: Review request for JDK-8043131: Move ShapedAndTranslucentWindows and GC functional AWT tests to regression tree

2014-06-04 Thread Petr Pchelko
Hello, Dmitriy. The new version looks fine to me. With best regards. Petr. On 04 июня 2014 г., at 11:46, Dmitriy Ermashov wrote: > Hi Petr, all, > > Please review next revision of webrev: > http://cr.openjdk.java.net/~yan/8043131/webrev.02/ > > 1. Set -Xmx20m key for GC tests > 2. Added @Ov

Re: Review request for JDK-8043131: Move ShapedAndTranslucentWindows and GC functional AWT tests to regression tree

2014-06-04 Thread Dmitriy Ermashov
Hi Petr, all, Please review next revision of webrev: http://cr.openjdk.java.net/~yan/8043131/webrev.02/ 1. Set -Xmx20m key for GC tests 2. Added @Override annotation for all corresponding self written methods. Thanks, Dima On 03.06.2014 16:33, Petr Pchelko wrote: Hello, Dmitriy. I think that

Re: Review request for JDK-8043131: Move ShapedAndTranslucentWindows and GC functional AWT tests to regression tree

2014-06-03 Thread Petr Pchelko
Hello, Dmitriy. I think that it worths adding -Xmx option to the GC tests as default max heap size is quite big. Also could you please add @Override to the initGui method as now it's not obvious where is it called from. Thank you. With best regards. Petr. On 03 июня 2014 г., at 15:21, Dmitriy

Re: Review request for JDK-8043131: Move ShapedAndTranslucentWindows and GC functional AWT tests to regression tree

2014-06-03 Thread Dmitriy Ermashov
Hi all, Please review the last version of fix for https://bugs.openjdk.java.net/browse/JDK-8043131 The webrev is here: http://cr.openjdk.java.net/~yan/8043131/webrev.01/ Test colocation for remaining ShapedAndTranslucent part of functional tests. The fix also includes remarks for the first part

Review request for JDK-8043131: Move ShapedAndTranslucentWindows and GC functional AWT tests to regression tree

2014-05-19 Thread Dmitriy Ermashov
Hi, Please review the changeset for bug: https://bugs.openjdk.java.net/browse/JDK-8043131 The webrev is here: http://cr.openjdk.java.net/~yan/8043131/webrev.00/ This is one more batch of functional AWT (ShapedAndTranslucentWindows and GC) tests are ought to be moved to regression tree. -- Th